New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ERROR: [Errno 2] grub-mkrescue failed to create the rescue image #63
Comments
Hi @Lowrida , please try running…
…and share its output, for more context. Thank you! |
|
@Lowrida my So booting a rescue shell in QEMU works, good. Can you try again with a real theme? E.g. I would do |
Yes, it works! But there are a few things..
|
@Lowrida cool, thanks for reporting back!
Nothing to worry about to much, other than maybe performance. Two ideas:
Please check if passing a custom resolution a la
I would need more info for any real chance on a idea why that would be happening. Can we rule out a bug in the theme? PS: What is the current understanding of why |
Passing --no-kvm did remove the error. I can send you the theme.txt or complete theme if you want? It is still in progress and i am working on the progressbar, but i got tired of rebooting every time, that's why i was searching for a preview tool. Why i opened the ticket at first.. I don't know why that error appeared? |
The theme as it is so far.. |
@Lowrida cool, thanks for reporting back.
I tried with your theme with a custom resolution and it worked over here, so it may have to do with the grub config you're using: What the argument does it is inserts a line like
That's probably possible with QEMU somehow.
That depends on your hardware archtecture, see grub2-theme-preview/grub2_theme_preview/__main__.py Lines 326 to 328 in 5194569
I'm afraid I cannot help with debugging at that level. I have lots of other things to do.
Okay, let me ask a different way: What is needed more in your eyes to fix and close issue "grub-mkrescue failed to create the rescue image"? |
Ok, so i open a new ticket for this?
Ah ok, that's what i wanted to know, which program is used. I have multiple qemu-* files... and i know not enough about qemu to asume automatically what file is used. I see that --full-screen can be used with qemu. But how do you use your --qemu COMMAND ?? They all don't work!
Then your program is not useful for me, because i expected it to show all parts of a theme on the right place. What is the point then to continue?
Ah ok. In that case, this ticket can be closed, because the first problem is solved! |
If you you like and can help with debugging it or can share
They don't, yes. From playing with full QEMU screen mode options over here now — e.g. display
I can fix bugs, but I cannot help everyone with their very theme. That doesn't scale.
Excellent, thanks for the update. |
No problem, i can do that
I don't understand what you try to tell here?
I do not need help with my theme. I can make my own theme, no problem with that! The problem is that your program does not show the objects at the right place! Because when i do a real boot, the objects are in the correct place on the screen! In the image they are not. So my conclusion is that the problem is not my theme, but somewere in your program, or qemu or whatever program is used... seems like a bug to me. |
@Lowrida thanks! For anyone else interested: This is ticket #64.
Okay, let me clarify. I was meaning to say that:
If you wanted to force #! /usr/bin/env bash
exec qemu-system-x86_64 -full-screen "$@" I can elaborate on that approach if it's not clear but of interest.
My guess (without having had a closer look) is that the coordinates used to put the objects on the screen are depending on screen size or aspect ratio. If that's true, either (a) the fix to #64 should make this work for free or (b) the theme needs to use relative coordinates rather than absolute ones. |
Not being rude, but that did not clarify things at all for me! ;) If you ask me, you could make a --fullscreen option in your program that passes the "-full-screen" to qemu. Seems to me that's a pretty simple solution.. in comparison to working with wrappers and aliases. I don't know what system you use, but qemu in fullscreen mode gave me no troubles more then the windows mode gave me. It was just as laggy as in windows mode. (yes it is slow, but in both modes) But i don't care if it is slow or not! I don't need it to be snappy, i need it to preview my grubmenu, nothing more, nothing less!
That is probably the problem. I use for most of the objects hard values for placement because percentage is way less accurate if it comes to the pixel! So with hard values and a corrupt aspect ratio of the screen size, the objects are placed wrong. But fullscreen mode would solve this problem i guess! ;) |
# which qemu-system-x86_64
/usr/bin/qemu-system-x86_64 The help output is this: # grub2-theme-preview --help | fgrep qemu | fgrep default
--qemu COMMAND KVM/QEMU command (default: qemu-system-<machine>) If that's not clear, what else could we put the to be more clear?
It would be possible, but (1) so far I have not yet seen that work well locally and (2) it is not clear to me yet which of the displays support that mode. |
Ok, let me be clear.. i'm not a noob with linux or programming. I think the miss understandings here is that english is for both of us not our native language. That said.. "qemu-system-x86_64" is not a command, it is an executable! When you execute it, THAT is a command! You give the system the command to execute it. --qemu <path/to/qemu> KVM/QEMU executable (default: qemu-system-) It would have been way more clear to me that i could manipulate which program to start AND that i could use a script/wrapper to execute it with any parameter possible!
It works on my system.. why wouldn't it support any display? The option is IN qemu itself. I think fullscreen mode is nothing more then a maximized window without the frame/titlebar. I still can switch desktops, ALT-Tab lets me get other windows on top of it and my quake style terminal does also show on top of it! |
I made a wrapper and started qemu with full screen.. well.. that brought some other problems with it! That whole fullscreen thing wouldn't even be necessary if resizing the window would also resize the grub menu. Because then i would double-click the titlebar to maximize the window and i get my aspect ratio of the screen, but that does not work! Seems it is not going to work on a wide screen... :/ |
I understand that term "command" does not communicate that it cannot be more than "a single word", i.e. that it cannot have arguments. However, the value from
There are QEMU displays other than # qemu-system-x86_64 -display help
Available display backend types:
none
gtk
sdl
egl-headless
curses Maybe we can expect the user to not combine non-window displays with fullscreen mode. I tried |
@Lowrida that's good to know.
I think it's because there's a screen in there. I'm not surprised that resize works this way.
Are you sure that there is not a single
Maybe it's got to do with the size of your resolution. I only have 1920x1080 here. Maybe QEMU needs to be convinced to use a emulate a non-default graphics card. E.g. there is a |
I just tried different display options, but that didn't work.. no support for sdl. Only gtk works. It tried it with gl=on but then i get fullscreen but with the wrong (small) aspect ratio again. Like in window mode.
Mmh.. could be indeed. But i noticed something else. When the first message pops up "Guest has not initialized display (yet)." All is nicely centered an correct resolution. Then the next screen comes in with some errors about disk something and the resolution jumps out of proportion!
I could try, but from what i understand it fixes the extra "set gfxmode=auto" bug. I manually fixed that with the custom grub config. I removed ALL the "set gfxmode=" and placed only one at the top of the config. So i don't think it will do anything helpful at this moment. But overall it should fix that bug in your program, so it is not bad to implement it.
Whoop-dee-hooo, "-vga virtio" did the trick! :) |
Debug says it copies the standard grub.cfg to the IMG.. but i point your program to a custom grub config...??
But i use this cmd to start: But when i open the IMG it does contain my custom grub! So maybe there is a bug in the debug output of that line? (btw, that resolution was just for testing purpose, but it does nothing) |
In the output line the left side is the target in the image (
Could elaborate? What is now working that previously didn't work? |
Fullscreen mode with everything working and correct aspect ratio of screen size!
If i copy the 'customgrub.cfg' and 'preview-theme.sh' to a theme folder i can't test it from there. |
...and btw, this page sucks with their code tags! |
@Lowrida code blocks need…
You're using single ticks above, which is for single-line inline code. That's rather strong language for a feature as useful as those tags 😃 If |
About the backticks, i click on the "add code" button in the edit window, so i asume that would be enough to add code. Nowere does it say that single backticks are for one liners and tripple for big text!? But nice to know that it works with tripple...
Well.. waddayaknow, it works! ;) I prefer these options in your program rather than having to deal with wrappers or aliases! |
…ull-screen Add arguments "--vga CARD" and "--full-screen" (related to #63)
I have installed all the requirements, but when i try to view a bootmenu i get this error!
I use the timeout option and the path to the theme..
The text was updated successfully, but these errors were encountered: