Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeout / progress notification not showing up #9

Closed
vitalogy opened this issue Jul 12, 2015 · 6 comments
Closed

Timeout / progress notification not showing up #9

vitalogy opened this issue Jul 12, 2015 · 6 comments

Comments

@vitalogy
Copy link

Hi,

i created a grub2-theme for gentoo, but the timeout notification shows not up in QEMU, neither the progrees_bar nor the quick test with the circular_progress. The same theme with Grub2 on my real machine shows me the progress_bar.So, is the timeout notification working with QEMU at all?

You can have a look at my repo:
https://github.com/vitalogy/grub2-theme-gentoo

The Screenshot is taken from QEMU, as you can see, there is no progress_bar.

And thanks for this little programm, it saves a lot of time.

@hartwork
Copy link
Owner

Hi!
Does your disk have the same version of GRUB 2.x installed as is used with grub2-theme-preview?
(I'm thinking the feature could be broken in latest releases of GRUB but you are running an older, working version in your MBR.)
It could take a few days until I get to really debugging that myself. I'm happy about any more debugging or details you could provide.
Thanks, S

@hartwork hartwork changed the title timeout notification Timeout notification not showing up? Jul 12, 2015
@vitalogy
Copy link
Author

hey,
my system is a few days old. So i bought a new SSD and made a fresh install.
The grub-version on my SSD should be the same, as i am using with QEMU ... but will check this.

@vitalogy
Copy link
Author

installed grub-version on SSD and installed grub-version in the system are the same

# emerge -pv grub

These are the packages that would be merged, in order:

Calculating dependencies... done!
[ebuild   R   ~] sys-boot/grub-2.02_beta2-r7:2::gentoo  USE="fonts multislot nls sdl themes truetype -debug -device-mapper -doc -efiemu -libzfs -mount -static {-test}" GRUB_PLATFORMS="efi-64 pc qemu -coreboot -efi-32 -emu -ieee1275 -loongson -multiboot -qemu-mips -uboot -xen" 0 KiB

Total: 1 package (1 reinstall), Size of downloads: 0 KiB

@hartwork
Copy link
Owner

To my understanding, the relevant GRUB modules are:

  • progress bar -> progress module
  • circular progress -> gfxmenu module

Inspecting the rescue image that is generated over here, it does contain both modules:

# find /mnt/tmp0wRpNf/boot/grub/ | grep -E '(gfxmenu|progress).mod'
/mnt/tmp0wRpNf/boot/grub/i386-pc/gfxmenu.mod
/mnt/tmp0wRpNf/boot/grub/i386-pc/progress.mod

@hartwork
Copy link
Owner

It turned out that I had put in

set timeout=-1

so that the QEMU preview would not close quickly. A side effect is, that it disables progress indicators. I didn't think of that. Many thanks for the report! I justed fixed it, also adding a new command line parameter --timeout SECONDS, see commit 2f6fde3.

hartwork added a commit that referenced this issue Jul 13, 2015
@hartwork
Copy link
Owner

Bumped to 1.3.1 in Gentoo, needs a moment to sync.

+*grub2-theme-preview-1.3.1 (13 Jul 2015)
+
+  13 Jul 2015; Sebastian Pipping <......>
+  +grub2-theme-preview-1.3.1.ebuild:
+  Bump to 1.3.1 with support for progress indicators
+

Closing.

Once you're happy with that theme of yours, let's add an ebuild for it to the grub2-themes-overlay.

Best, S

@hartwork hartwork changed the title Timeout notification not showing up? Timeout / progress notification not showing up Jul 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants