Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infrastructure update #132

Merged
merged 5 commits into from Aug 18, 2020
Merged

Infrastructure update #132

merged 5 commits into from Aug 18, 2020

Conversation

rebeccacremona
Copy link
Collaborator

@rebeccacremona rebeccacremona commented Aug 18, 2020

This PR:

  • Changes the file structure of the repo a bit, to make it more like recent LIL projects. Notably, one of the directories named perma-payments is now named web. I did NOT change the Django app from perma_payments to our now-usual main, because that would have required extensive changes across most files, and would affect the db and migrations; I don't think it's worth it.

  • Switches from pipenv to pip-tools, and, to facilitate that, switches the base Docker image from plain debian:buster to python:3.7-buster

  • Upgrades to Django 2.2. (I stopped there, rather than going all the way to Django 3.0 or 3.1, because 2.2 is the current LTS version, and Jack recommends sticking with those.)

  • Upgrades the rest of python packages

The changes to the file structure and the move to pip-tools will certainly require changes to our deployments and deployment scripts... I think it's worth it, so that, after I similarly alter Perma, all our projects use pip-tools.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 95.276% when pulling 233cbf7 on rebeccacremona:updates into f98c6bd on harvard-lil:develop.

@bensteinberg bensteinberg merged commit 65674c3 into harvard-lil:develop Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants