Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

major overhaul of inner mechanics of package #11

Closed
wants to merge 26 commits into from
Closed

major overhaul of inner mechanics of package #11

wants to merge 26 commits into from

Conversation

joshyam-k
Copy link
Collaborator

@joshyam-k joshyam-k commented Jan 19, 2024

  • population data is no longer passed to fit_zi() or boot_rep()
  • fit_zi() just returns model parameters for a single fitting and boot_rep() returns parameters from each model fitting in the bootstrap in nicely formatted matrices
  • full mse estimation now happens in a function called generate_mse() which formats outputs before passing to an optimized c++ function called dom_preds_calc

Still to do:

  • catch and remove occasional NA's
  • benchmark more thoroughly
  • allow new levels (see allow new levels #10)

@joshyam-k
Copy link
Collaborator Author

This PR also renames the main function (unit_zi -> saeczi)

@joshyam-k
Copy link
Collaborator Author

closing for now to fix some issues...

@joshyam-k joshyam-k closed this Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants