Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency in data_utils.py #6

Closed
Harold-Lee-PKU opened this issue Mar 3, 2018 · 1 comment
Closed

Inconsistency in data_utils.py #6

Harold-Lee-PKU opened this issue Mar 3, 2018 · 1 comment

Comments

@Harold-Lee-PKU
Copy link

In data_utils.py, according to line 134, the tokes are expected to be "not annoying_number_word(...)", so the annoying_number_word() should return True when the toke should be ignored. Yet at line 116, the annoying_number_word() returns True when the toke should not be ignored. I think this bug may affect the generation model as well as the extraction model.

@swiseman
Copy link
Contributor

swiseman commented Mar 3, 2018

Yes, thanks for pointing this out; looks like this results in numeric words (e.g., "thirty four") largely being ignored, though of course numbers are extracted. And I agree we should get results for including numeric words as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants