fix inconsistent interface implementation #51
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The interface implementation in
pytorch-struct/torch_struct/cky.py
Line 73 in f9f2530
Is inconsistent with its declaration in
pytorch-struct/torch_struct/helpers.py
Line 139 in 876588d
resulting in an error when invoking
topk()
pytorch-struct/torch_struct/distributions.py
Lines 96 to 98 in 876588d
This pr will raise an error when invoking unsupported
topk()
withCKY
.