Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HARVESTER: add query params for pcidevices list #717

Merged
merged 1 commit into from May 12, 2023

Conversation

DaiYuzeng
Copy link

@DaiYuzeng DaiYuzeng commented May 10, 2023

Summary

PR Checklist

  • Is this a multi-tenancy feature/bug?
    • Yes, the relevant RBAC changes are at:
  • Do we need to backport changes to the old Rancher UI, such as RKE1?
    • Yes, the relevant PR is at:
  • Are backend engineers aware of UI changes?

Fixes #

Occurred changes and/or fixed issues

harvester/harvester#2763

  1. Number Of Virtual Functions are links now, the page will go to pci device list directly if you click them. And the list should only display the devices belonged this sr-iov. (won't implement now)
  2. Virtual Functions Addresses are also links now, the page will go to pci device list directly if you click them. And there is only one record.

Technical notes summary

Areas or cases that should be tested

  1. Go to SR-IOV list page.
  2. Enable one of the SR-IOV devices, set virtual functions as 10.
  3. You should be able to click Show More to show all vfs addresses.
  4. You should be able to redirect to PCI device list page and you should only see the result of search.

Areas which could experience regressions

Screenshot/Video

image

@DaiYuzeng DaiYuzeng marked this pull request as draft May 10, 2023 07:29
@DaiYuzeng DaiYuzeng force-pushed the fix-2763 branch 5 times, most recently from 9054725 to 809537c Compare May 11, 2023 06:47
@DaiYuzeng DaiYuzeng marked this pull request as ready for review May 11, 2023 07:00
@DaiYuzeng DaiYuzeng marked this pull request as draft May 11, 2023 07:41
@DaiYuzeng DaiYuzeng force-pushed the fix-2763 branch 2 times, most recently from 4d04e33 to 5409e7a Compare May 11, 2023 08:01
@DaiYuzeng DaiYuzeng marked this pull request as ready for review May 11, 2023 08:38
@DaiYuzeng DaiYuzeng requested a review from WuJun2016 May 11, 2023 08:41
@WuJun2016 WuJun2016 requested review from n313893254 and removed request for WuJun2016 May 11, 2023 08:52
Copy link

@n313893254 n313893254 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

image

@WuJun2016 WuJun2016 merged commit 781377e into harvester:master May 12, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants