Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add workaround for the USB installation issue #432

Merged
merged 1 commit into from
Sep 14, 2023
Merged

doc: add workaround for the USB installation issue #432

merged 1 commit into from
Sep 14, 2023

Conversation

Vicente-Cheng
Copy link
Contributor

@harvesterhci-io-github-bot
Copy link
Collaborator

✅ Deploy Preview for harvester-preview ready!

Name Link
🔨 Latest commit 1fda53a
🔍 Latest deploy log https://app.netlify.com/sites/harvester-preview/deploys/650279356632e608480bcf01
😎 Deploy Preview https://650279356632e608480bcf01--harvester-preview.netlify.app

bk201
bk201 reviewed Sep 13, 2023
View reviewed changes
docs/install/usb-install.md Outdated Show resolved Hide resolved
@Vicente-Cheng Vicente-Cheng force-pushed the harvester-4510-doc branch 2 times, most recently from ee828a8 to 08dad25 Compare September 13, 2023 08:57
guangbochen
guangbochen reviewed Sep 13, 2023
View reviewed changes
docs/install/usb-install.md Outdated Show resolved Hide resolved
docs/install/usb-install.md Outdated Show resolved Hide resolved
docs/install/usb-install.md Outdated Show resolved Hide resolved
docs/install/usb-install.md Outdated Show resolved Hide resolved
docs/install/usb-install.md Outdated Show resolved Hide resolved
docs/install/usb-install.md Outdated Show resolved Hide resolved
docs/install/usb-install.md Outdated Show resolved Hide resolved
docs/install/usb-install.md Outdated Show resolved Hide resolved
guangbochen
guangbochen approved these changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@guangbochen guangbochen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

bk201
bk201 approved these changes Sep 13, 2023
View reviewed changes
Copy link
Member

@bk201 bk201 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot!

LucasSaintarbor
LucasSaintarbor approved these changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@LucasSaintarbor LucasSaintarbor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small NITs. LGTM. Lmk if these changes are okay, thanks!

docs/install/usb-install.md Outdated Show resolved Hide resolved
docs/install/usb-install.md Outdated Show resolved Hide resolved
docs/install/usb-install.md Show resolved Hide resolved
docs/install/usb-install.md Outdated Show resolved Hide resolved
docs/install/usb-install.md Outdated Show resolved Hide resolved
@Vicente-Cheng @guangbochen
@bk201 @LucasSaintarbor
doc: add workaround for the USB installation issue
1fda53a 
Signed-off-by: Vicente Cheng <vicente.cheng@suse.com>
Co-authored-by: Guangbo <guangbo.chen@suse.com>
Co-authored-by: Kiefer Chang <kiefer.chang@suse.com>
Co-authored-by: Lucas Saintarbor <lucas.saintarbor@suse.com>
@Vicente-Cheng
Copy link
Contributor Author

Small NITs. LGTM. Lmk if these changes are okay, thanks!

Hi @LucasSaintarbor, updated all suggestions as you mentioned.
Thanks for reviewing it!

@Vicente-Cheng Vicente-Cheng merged commit 88841de into harvester:main Sep 14, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bk201 bk201 bk201 approved these changes

@guangbochen guangbochen guangbochen approved these changes

@LucasSaintarbor LucasSaintarbor LucasSaintarbor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Vicente-Cheng @harvesterhci-io-github-bot @bk201 @guangbochen @LucasSaintarbor