Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: description and workaround for known issue #5841 #571

Merged
merged 1 commit into from
May 24, 2024

Conversation

WebberHuang1118
Copy link
Member

@WebberHuang1118 WebberHuang1118 commented May 23, 2024

description and workaround for known issue #5841

@harvesterhci-io-github-bot
Copy link
Collaborator

harvesterhci-io-github-bot commented May 23, 2024

Deploy Preview for harvester-preview ready!

Name Link
🔨 Latest commit 7524c51
🔍 Latest deploy log https://app.netlify.com/sites/harvester-preview/deploys/664ff9f04d7a5fbcf5abac35
😎 Deploy Preview https://664ff9f04d7a5fbcf5abac35--harvester-preview.netlify.app

Copy link
Member

@bk201 bk201 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can mention backing up a running VM is fine and suggest users to start the VM first to backup the VM to avoid the issue.

@WebberHuang1118
Copy link
Member Author

We can mention backing up a running VM is fine and suggest users to start the VM first to backup the VM to avoid the issue.

Updated per suggestion, thanks.

Copy link
Contributor

@jillian-maroket jillian-maroket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WebberHuang1118 Let me know if you have concerns about the changes.

versioned_docs/version-v1.2/vm/backup-restore.md Outdated Show resolved Hide resolved
versioned_docs/version-v1.2/vm/backup-restore.md Outdated Show resolved Hide resolved
versioned_docs/version-v1.2/vm/backup-restore.md Outdated Show resolved Hide resolved
versioned_docs/version-v1.2/vm/backup-restore.md Outdated Show resolved Hide resolved
versioned_docs/version-v1.2/vm/backup-restore.md Outdated Show resolved Hide resolved
versioned_docs/version-v1.2/vm/backup-restore.md Outdated Show resolved Hide resolved
versioned_docs/version-v1.2/vm/backup-restore.md Outdated Show resolved Hide resolved
versioned_docs/version-v1.2/vm/backup-restore.md Outdated Show resolved Hide resolved
versioned_docs/version-v1.2/vm/backup-restore.md Outdated Show resolved Hide resolved
versioned_docs/version-v1.2/vm/backup-restore.md Outdated Show resolved Hide resolved
@WebberHuang1118
Copy link
Member Author

Hi @jillian-maroket,
I updated the content based on your suggestion and had some slight modifications (Longhorn Snapshot and Longhorn Backup both are resources in Longhorn system).

Please check it, thanks.

Copy link
Member

@bk201 bk201 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

Signed-off-by: Webber Huang <webber.huang@suse.com>

Co-authored-by: Jillian <67180770+jillian-maroket@users.noreply.github.com>
Copy link
Contributor

@jillian-maroket jillian-maroket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WebberHuang1118 LGTM. Thanks!

@WebberHuang1118 WebberHuang1118 merged commit 3bea418 into harvester:main May 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants