Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add harvester-crd chart #194

Merged
merged 1 commit into from
Dec 16, 2021
Merged

Add harvester-crd chart #194

merged 1 commit into from
Dec 16, 2021

Conversation

FrankYang0529
Copy link
Member

@FrankYang0529 FrankYang0529 commented Dec 15, 2021 •
edited by guangbochen

@FrankYang0529 FrankYang0529 force-pushed the add-crds-chart branch 3 times, most recently from e032093 to 4a7677a Compare December 16, 2021 08:39
@FrankYang0529 FrankYang0529 marked this pull request as ready for review December 16, 2021 10:07
@FrankYang0529
Add harvester-crd chart
49a89bc 
Signed-off-by: Frank Yang <poan.yang@suse.com>
weihanglo
weihanglo approved these changes Dec 16, 2021
View reviewed changes
Copy link
Contributor

@weihanglo weihanglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built the ISO and installed it successfully

gitlawr
gitlawr approved these changes Dec 16, 2021
View reviewed changes
Copy link
Contributor

@gitlawr gitlawr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bk201
bk201 approved these changes Dec 16, 2021
View reviewed changes
Copy link
Member

@bk201 bk201 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for fixing it.

@bk201 bk201 merged commit 65368b7 into harvester:master Dec 16, 2021
@FrankYang0529 FrankYang0529 deleted the add-crds-chart branch December 16, 2021 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bk201 bk201 bk201 approved these changes

@guangbochen guangbochen guangbochen approved these changes

@gitlawr gitlawr gitlawr approved these changes

@weihanglo weihanglo weihanglo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@FrankYang0529 @bk201 @guangbochen @gitlawr @weihanglo