Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Visual bug if the node has more than 1000 GB #3607

Closed
n313893254 opened this issue Mar 7, 2023 · 2 comments
Closed

[BUG] Visual bug if the node has more than 1000 GB #3607

n313893254 opened this issue Mar 7, 2023 · 2 comments
Assignees
Labels
area/ui kind/bug Issues that are defects reported by users or that we know have reached a real release not-require/test-plan Skip to create a e2e automation test issue priority/0 Must be fixed in this release reproduce/always Reproducible 100% of the time require-ui/small estimate 1-2 working days severity/1 Function broken (a critical incident with very high impact)
Milestone

Comments

@n313893254
Copy link

n313893254 commented Mar 7, 2023

Describe the bug

When a node has more than 1TB of RAM there is a visual bug in UI. UI displays memory size correctly, but on nodes with >1TB od RAM the formatting is broken and info takes 2 lines.

To Reproduce
Steps to reproduce the behavior:

  1. Go to the Host list page
  2. Check the host memory size

Expected behavior

UI should display memory size correctly formatted even on nodes with a lot of memory.

Support bundle

Environment

  • Harvester ISO version: SUSE Harvester 1.1.1
  • Underlying Infrastructure (e.g. Baremetal with Dell PowerEdge R630):

Additional context
Add any other context about the problem here.

@n313893254 n313893254 added kind/bug Issues that are defects reported by users or that we know have reached a real release area/ui priority/0 Must be fixed in this release severity/4 Function working but has a minor issue (a minor incident with low impact) reproduce/always Reproducible 100% of the time labels Mar 7, 2023
@n313893254 n313893254 added this to the v1.2.0 milestone Mar 7, 2023
@n313893254 n313893254 self-assigned this Mar 7, 2023
@WuJun2016 WuJun2016 added severity/1 Function broken (a critical incident with very high impact) and removed severity/4 Function working but has a minor issue (a minor incident with low impact) labels Mar 22, 2023
@WuJun2016 WuJun2016 assigned DaiYuzeng and unassigned n313893254 Mar 24, 2023
@DaiYuzeng DaiYuzeng added not-require/test-plan Skip to create a e2e automation test issue require-ui/small estimate 1-2 working days labels Mar 27, 2023
@harvesterhci-io-github-bot
Copy link

harvesterhci-io-github-bot commented Mar 27, 2023

Pre Ready-For-Testing Checklist

  • [ ] If labeled: require/HEP Has the Harvester Enhancement Proposal PR submitted?
    The HEP PR is at:

  • Where is the reproduce steps/test steps documented?
    The reproduce steps/test steps are at: [BUG] Visual bug if the node has more than 1000 GB #3607 (comment)

  • [ ] Is there a workaround for the issue? If so, where is it documented?
    The workaround is at:

  • [ ] Have the backend code been merged (harvester, harvester-installer, etc) (including backport-needed/*)?
    The PR is at:

    • Does the PR include the explanation for the fix or the feature?

    • Does the PR include deployment change (YAML/Chart)? If so, where are the PRs for both YAML file and Chart?
      The PR for the YAML change is at:
      The PR for the chart change is at:

  • If labeled: area/ui Has the UI issue filed or ready to be merged?
    The UI issue/PR is at: HARVESTER: configure column min-width dashboard#678

  • [ ] If labeled: require/doc, require/knowledge-base Has the necessary document PR submitted or merged?
    The documentation/KB PR is at:

  • If NOT labeled: not-require/test-plan Has the e2e test plan been merged? Have QAs agreed on the automation test case? If only test case skeleton w/o implementation, have you created an implementation issue?

    • The automation skeleton PR is at:
    • The automation test case PR is at:
  • If the fix introduces the code for backward compatibility Has a separate issue been filed with the label release/obsolete-compatibility?
    The compatibility issue is filed at:

@TachunLin
Copy link

TachunLin commented May 9, 2023

Verifing fixed on master-2ba017d4-head (05/05). Close this issue.

Result

  • When the nodes contains cpu, memory and disk size between 1000 GiB to 1023GiB ( four digits), the node resource column display layout should display correctly without wrapping to the newline
    image

  • And on edge case, we can also set the the cpu, memory and disk size to extremely large digits (10 digits) , the node resource column display layout should display correctly without wrapping to the newline
    image

Test Information

  • Test Environment: single node harvester on local kvm machine
  • Harvester version: master-2ba017d4-head (05/05)

Verify Steps

  1. Use ipxe-example to provision Harvester cluster
  2. edit settings.yml
  3. Set cluster.disk_size to 1145G
  4. Check the host page after Harvester cluster provisioning ready
  5. Use developer tool to change the value of Reserved and Used CPU, Memory and Storage size
  6. Check the host page for the layout

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui kind/bug Issues that are defects reported by users or that we know have reached a real release not-require/test-plan Skip to create a e2e automation test issue priority/0 Must be fixed in this release reproduce/always Reproducible 100% of the time require-ui/small estimate 1-2 working days severity/1 Function broken (a critical incident with very high impact)
Projects
None yet
Development

No branches or pull requests

5 participants