[BUG] User can update Resource Quotas to hit the limits, then migration will fail silently

[lanfon72]

Describe the bug

vokoscreenNG-2023-05-25_20-09-35.mp4

To Reproduce

Steps to reproduce the behavior:

1. Install Harvester with at least 2 nodes
2. Import Harvester into Rancher
3. Access Harvester via Rancher's Virtualization Management
4. Navigate to Advanced/Settings, update overcommit-config to cpu:100, memory:100
5. Navigate to Projects/Namespaces, Create Project proj-a with Resource Quotas
   • CPU Limit: 5000 mCPUs/Project Limit, 3000 mCPUs/Namespace Default Limit
   • Memory Limit: 5000 MiB/Project Limit, 4000 MiB/Namespace Default Limit
6. Create Namespace ns-1 under Project proj-a
7. Create a image for VM creation
8. Create 2 VMs belong to namespace ns-1
   • Named vm1 with CPU: 1C, Memory 1GiB
   • Named vm2 with CPU: 1C, Memory 2GiB
9. Update Namespace ns-1 to set Memory Limit to 3500
10. Migrate vm1 to another node

Expected behavior

We might need to check current used quotas when user going to reduce it.

Environment:

• Harvester ISO version: v1.2.0-rc1
• ui-source Option: Auto
• Underlying Infrastructure (e.g. Baremetal with Dell PowerEdge R630): Baremetal DL360 3 nodes
• Rancher Version:
  • v2.6-a4b924d21cd5d90b28ab8009edc18d96542952ac-head, Docker Image: a1d1e43988d2
  • v2.7-fbca7c34e5aeae36b85d8b0e9af12a2f6f13e0ea-head, Docker Image: 73f3b3456e62

Additional context

Discovered when testing #3124

[harvesterhci-io-github-bot]

Pre Ready-For-Testing Checklist

• If labeled: require/HEP Has the Harvester Enhancement Proposal PR submitted?
  The HEP PR is at:

• Where is the reproduce steps/test steps documented?
  The reproduce steps/test steps are at: [BUG] User can update Resource Quotas to hit the limits, then migration will fail silently #3974

• Is there a workaround for the issue? If so, where is it documented?
  The workaround is at:

• Have the backend code been merged (harvester, harvester-installer, etc) (including backport-needed/*)?
  The PR is at: ResourceQuota add insufficient resource annotation and fixed vm when in starting #3966

  • Does the PR include the explanation for the fix or the feature?

  • Does the PR include deployment change (YAML/Chart)? If so, where are the PRs for both YAML file and Chart?
    The PR for the YAML change is at:
    The PR for the chart change is at:

• If labeled: area/ui Has the UI issue filed or ready to be merged?
  The UI issue/PR is at:

• If labeled: require/doc, require/knowledge-base Has the necessary document PR submitted or merged?
  The documentation/KB PR is at:

• If NOT labeled: not-require/test-plan Has the e2e test plan been merged? Have QAs agreed on the automation test case? If only test case skeleton w/o implementation, have you created an implementation issue?

  • The automation skeleton PR is at:
  • The automation test case PR is at:

• If the fix introduces the code for backward compatibility Has a separate issue been filed with the label release/obsolete-compatibility?
  The compatibility issue is filed at:

[harvesterhci-io-github-bot]

Automation e2e test issue: harvester/tests#832

[lanfon72]

Verified this bug has been fixed.

Test Information

• Environment: qemu/KVM 2 nodes
• Harvester Version: v1.2.0-rc2
• ui-source Option: Auto
• Rancher Version: v2.7-9a33c24de30c81f2ecd900d923d16d7fb2020929-head (Docker Image: sha256:3c0baa609934e8b1c90fde38d9f96526ac0dc52c00702d130480ac5792922e15)

Verify Steps

• Follow Steps to reproduce in [BUG] User can update Resource Quotas to hit the limits, then migration will fail silently #3974 (comment)
• User will not able to reduce resource quotas to less than used.