Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set proper ccm & csi maximum version #3710

Merged
merged 1 commit into from Mar 23, 2023

Conversation

guangbochen
Copy link
Contributor

@guangbochen guangbochen commented Mar 23, 2023

IMPORTANT: Please do not create a Pull Request without creating an issue first.

Problem:
The current default value is invalid, as it will prevent users from successfully selecting the Harvester cloud provider when creating or modifying the RKE2 Kubernetes cluster.

Solution:
Update the CSI & CCM maximum supported versions (We will bump the chart minor release version if it contains a significant design change). e.g.,

Harvester version RKE2 with old CCM design RKE2 with new CCM design( v0.2 - #2134)
>= v1.2 Supported Supported
< v1.2 Supported Not Supported

Related Issue:
#3404

Test plan:

  • import an existing Harvester cluster(e.g., v1.1.2-rc3) into a Rancher server (>= v2.6.9 or v2.7)
  • spin up a guest RKE2 k8s cluster(>= v1.24.10); its built-in Harvester CCM chart version is v0.1.14, and users can still select the Harvester cloud provider, but its configured harvester-csi-ccm-versions setting value is "harvester-cloud-provider":">=0.0.1 <0.1.14".
  • replace the ui-dashboard-index value in the Rancher global setting page - request it from @n313893254
  • you should not be able to select the Harvester cloud provider as the UI validation is enabled with the above modification.
  • update the Harvester management chart, and patch the Harvester API server with a custom image(or patch the Harvester default setting value manually to {"harvester-cloud-provider":">=0.0.1 <0.2.0","harvester-csi-provider":">=0.0.1 <0.2.0"})
  • now, you should be able to select the Harvester cloud provider correctly.

@guangbochen guangbochen marked this pull request as ready for review March 23, 2023 10:43
Copy link
Contributor

@yaocw2020 yaocw2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@guangbochen guangbochen merged commit f27ede0 into harvester:master Mar 23, 2023
4 checks passed
@guangbochen
Copy link
Contributor Author

guangbochen commented Mar 23, 2023

@mergify backport v1.1

@mergify
Copy link

mergify bot commented Mar 23, 2023

backport v1.1.

❌ No backport have been created

  • Backport to branch v1.1. failed

GitHub error: Branch not found

@mergify
Copy link

mergify bot commented Mar 23, 2023

backport v1.1

✅ Backports have been created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants