Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up containerDisk(cd-rom type) volumes after enjectCDROM #3913

Merged
merged 1 commit into from May 17, 2023
Merged

Clean up containerDisk(cd-rom type) volumes after enjectCDROM #3913

merged 1 commit into from May 17, 2023

Conversation

futuretea
Copy link
Contributor

@futuretea futuretea commented May 17, 2023 •
edited

IMPORTANT: Please do not create a Pull Request without creating an issue first.

Problem:

after enject cdrom, container disk volume didn't removed

Solution:

fix the clean up logic

Related Issue:
#3914

Test plan:

  1. Create a windows vm from windows iso template
  2. Enject all cd-rom disk by EnjectCDROM
  3. check yaml by Edit Yaml

containerDisk volume should be removed

@futuretea futuretea marked this pull request as ready for review May 17, 2023 01:30
@futuretea
Clean up cd-rom volumes after enject
6f72f0e 
Signed-off-by: futuretea <Hang.Yu@suse.com>
@futuretea futuretea changed the title Clean up cd-rom volumes after enject Clean up containerDisk volumes after enjectCDROM May 17, 2023
@guangbochen guangbochen requested a review from chrisho May 17, 2023 02:12
@futuretea futuretea changed the title Clean up containerDisk volumes after enjectCDROM Clean up containerDisk(cd-rom type) volumes after enjectCDROM May 17, 2023
guangbochen
guangbochen approved these changes May 17, 2023
View reviewed changes
Copy link
Contributor

@guangbochen guangbochen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

chrisho
chrisho approved these changes May 17, 2023
View reviewed changes
Copy link
Contributor

@chrisho chrisho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it works fine, thanks.

@chrisho chrisho merged commit 25d478c into harvester:master May 17, 2023
5 checks passed
@futuretea
Copy link
Contributor Author

@mergify backport v1.1

@mergify
Copy link

mergify bot commented May 17, 2023 •
edited

backport v1.1

✅ Backports have been created

@mergify mergify bot mentioned this pull request May 17, 2023
Merged
@futuretea futuretea mentioned this pull request May 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisho chrisho chrisho approved these changes

@guangbochen guangbochen guangbochen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@futuretea @chrisho @guangbochen