Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport v1.3] make VirtualMachineImageSourceType an enum (#5511) #5850

Conversation

m-ildefons
Copy link
Contributor

Backport of PR #5511 onto v1.3 branch.

Related Issue:
Original Issue: #5510
Backport Issue: #5518

Signed-off-by: Moritz Röhrich <moritz.rohrich@suse.com>
@m-ildefons m-ildefons added the area/api Harvester API server label May 22, 2024
@m-ildefons m-ildefons requested a review from bk201 May 22, 2024 07:13
@m-ildefons m-ildefons self-assigned this May 22, 2024
Copy link
Member

@bk201 bk201 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Member

@WebberHuang1118 WebberHuang1118 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@WebberHuang1118 WebberHuang1118 merged commit 95b4f9d into harvester:v1.3 May 22, 2024
4 checks passed
bk201 pushed a commit to bk201/harvester that referenced this pull request May 23, 2024
Signed-off-by: Moritz Röhrich <moritz.rohrich@suse.com>
bk201 pushed a commit that referenced this pull request May 24, 2024
Signed-off-by: Moritz Röhrich <moritz.rohrich@suse.com>
m-ildefons added a commit to m-ildefons/docs that referenced this pull request May 31, 2024
Update swagger.json file with regenerated content from the latest HEAD
of the v1.3 branch. This updates the v1.3 API docs, including the
changes introduced by the backport of
harvester/harvester#5511
here: harvester/harvester#5850

Signed-off-by: Moritz Röhrich <moritz.rohrich@suse.com>
m-ildefons added a commit to m-ildefons/docs that referenced this pull request Jun 10, 2024
Update swagger.json file with regenerated content from the latest HEAD
of the v1.3 branch. This updates the v1.3 API docs, including the
changes introduced by the backport of
harvester/harvester#5511
here: harvester/harvester#5850

Signed-off-by: Moritz Röhrich <moritz.rohrich@suse.com>
m-ildefons added a commit to m-ildefons/docs that referenced this pull request Jun 27, 2024
Update swagger.json file with regenerated content from the latest HEAD
of the v1.3 branch. This updates the v1.3 API docs, including the
changes introduced by the backport of
harvester/harvester#5511
here: harvester/harvester#5850

Signed-off-by: Moritz Röhrich <moritz.rohrich@suse.com>
m-ildefons added a commit to harvester/docs that referenced this pull request Jun 27, 2024
Update swagger.json file with regenerated content from the latest HEAD
of the v1.3 branch. This updates the v1.3 API docs, including the
changes introduced by the backport of
harvester/harvester#5511
here: harvester/harvester#5850

Signed-off-by: Moritz Röhrich <moritz.rohrich@suse.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api Harvester API server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants