Add annotations when creating load balancer #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaocw2020
force-pushed
the
lbannotations
branch
2 times, most recently
from
f0fd8c7
to
78dd5c2
Compare
yaocw2020
force-pushed
the
lbannotations
branch
2 times, most recently
from
236bf9e
to
74cd092
Compare
futuretea
reviewed
Jun 15, 2023
chrisho
reviewed
Jun 15, 2023
guangbochen
reviewed
Jun 15, 2023
bk201
reviewed
Jun 15, 2023
guangbochen
reviewed
Jun 15, 2023
- loadbalancer.harvesterhci.io/network - loadbalancer.harvesterhci.io/project - loadbalancer.harvesterhci.io/namespace
bk201
approved these changes
Jun 15, 2023
chrisho
approved these changes
Jun 15, 2023
guangbochen
approved these changes
Jun 15, 2023
There was a problem hiding this comment.
LGTM, verified that the guest LB with IP pool config can get IP correctly, thanks.
apiVersion: loadbalancer.harvesterhci.io/v1beta1 │
│ kind: LoadBalancer │
│ metadata: │
│ annotations: │
│ loadbalancer.harvesterhci.io/cluster: rke2-lb │
│ loadbalancer.harvesterhci.io/namespace: default │
│ loadbalancer.harvesterhci.io/network: default/vlan1238 │
│ loadbalancer.harvesterhci.io/project: c-m-28b8nfb4/p-srzp5 │
│ creationTimestamp: "2023-06-15T10:24:30Z" │
│ finalizers: │
│ - wrangler.cattle.io/harvester-lb-controller │
│ generation: 2 │
│ labels: │
│ cloudprovider.harvesterhci.io/cluster: rke2-lb │
│ cloudprovider.harvesterhci.io/serviceName: foo │
│ cloudprovider.harvesterhci.io/serviceNamespace: default │
│ name: rke2-lb-default-foo-a794f73b │
│ namespace: default │
│ resourceVersion: "17018118" │
│ uid: eb377caa-e3b8-4f0c-b776-f7b4a5408290 │
│ spec: │
│ ipam: pool │
│ workloadType: cluster │
│ status: │
│ address: 10.84.103.193 │
│ allocatedAddress: │
│ gateway: 10.84.103.254 │
│ ip: 10.84.103.193 │
│ ipPool: guest-rke2 │
│ mask: 255.255.255.192 │
│ conditions: │
│ - lastUpdateTime: "2023-06-15T10:24:30Z" │
│ status: "True" │
│ type: Ready │
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add annotations
IP pool module will select the IP pool automatically according to those annotations.
Related issue: harvester/harvester#2134
Dependency chart PR: harvester/charts#178