Sriov support #45
Merged
Sriov support #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should review this post v1.1.2 |
ibrokethecloud
force-pushed
the
sriov-capability
branch
from
4e48255
to
a07c314
Compare
|
I'm reviewing this now, and I'll take care of the merge conflicts and push up the rebase |
tlehman
suggested changes
Mar 13, 2023
ibrokethecloud
force-pushed
the
sriov-capability
branch
from
31eae85
to
26efc70
Compare
ibrokethecloud
force-pushed
the
sriov-capability
branch
from
26efc70
to
43b6739
Compare
ibrokethecloud
force-pushed
the
sriov-capability
branch
from
a9aac71
to
aad477a
Compare
|
validation webhook now prevents PCIDeviceClaim from being disabled if it is already in use by a workload
related issue: harvester/harvester#3771 |
|
validation webhook prevents SRIOVNetworkDevice from being disabled if a VF is bound to a PCIDeviceClaim
|
|
validation webhook prevents pcideviceclaim to be created if pcidevice has no iommuGroup information. This avoids spamming the pcidevice controller with failed reconciles as binding to vfio-pci driver will not be successful without a iommu group.
related issue: harvester/harvester#3833 |
|
@ibrokethecloud Interesting, let me go find out how IOMMU Groups and SR-IOV VFs interact. |
bk201
approved these changes
May 5, 2023
|
Added additional check in nichelper to skip non pci nics. This will address: harvester/harvester#3650 |
|
The new change lgtm! |
futuretea
reviewed
May 15, 2023
futuretea
reviewed
May 16, 2023
guangbochen
reviewed
May 16, 2023
ibrokethecloud
force-pushed
the
sriov-capability
branch
from
cf2e75d
to
e57c88b
Compare
guangbochen
approved these changes
May 17, 2023
SriovDevice is used to identify and record all sr-iov capable nics across the cluster. End users can control the enable / disable / configuration of VF's of underlying hardware by interfacting with corresponding object. Once enabled, the configured VF's show up as normal PCI devices available for pass-through to workload VM's. Node type is just used to create an object corresponding to each node in the cluster and is used via the controller requeue mechanism to trigger recurring reconciles of the PCI and SRIOV enabled devices. node controller registration renamed sriovdevices crd to sriovnetworkdevices changes to naming of methods and objects handle changes to skip pcibridge devices during node reconcile drop unwanted imports fixed unit tests for pcidevice controller updated dapper to use downloads.opensuse.org, and fixed trivy ci failures minor change to status updates when sriov device is enabled changed test script copy VFList to allow override of default sysPciBus path for tests with umockdev renamed sriov handler based on codefactor report use /host/proc to query host network ns without host networking addition of validating webhooks and changes to sriov device status moved vm lookup to use lists rather than custom index removed duplicates from Dockerfile.dapper label pcidevices with sriov details, skip non pcidevice nics cleanup based on pr feedback moved NODE_NAME to env variable and cleaned up nodename key references added debug logging for pcidevices label lookup and sriov webhook
ibrokethecloud
force-pushed
the
sriov-capability
branch
from
fd6b334
to
ea57ed3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR introduces new SriovDevice and Node types.
IMPORTANT: Please do not create a Pull Request without creating an issue first.
Problem:
Support for sriov in harvester
Solution:
SriovDevice is used to identify and record all sr-iov capable nics across the cluster.
End users can control the enable / disable / configuration of VF's of underlying hardware by interfacting with corresponding object.
Once enabled, the configured VF's show up as normal PCI devices available for pass-through to workload VM's.
Node type is just used to create an object corresponding to each node in the cluster and is used via the controller requeue mechanism to trigger recurring reconciles of the PCI and SRIOV enabled devices.
Related Issue:
harvester/harvester#2763
Test plan: