ci: remove dist directory

[starbops]

IMPORTANT: Please do not create a Pull Request without creating an issue first.

Problem:

In the Run dapper step of the newly introduced GitHub Actions workflow, there's an obscure error message that we didn't catch during PR #30 review:

time="2024-04-25T14:09:33Z" level=info msg="docker cp /go/src/github.com/harvester/vm-dhcp-controller/bin ."
time="2024-04-25T14:09:34Z" level=info msg="docker cp /go/src/github.com/harvester/vm-dhcp-controller/dist ."
Error response from daemon: Could not find the file /go/src/github.com/harvester/vm-dhcp-controller/dist in container vm-dhcp-controller-CapmMhO
time="2024-04-25T14:09:34Z" level=info msg="docker cp /go/src/github.com/harvester/vm-dhcp-controller/chart/crds chart"

We've removed the copy of binaries to the dist/ directory but didn't remove it from Dockerfile.dapper. So Dapper will still try to copy the built artifacts from that directory, which no longer exist, thus causing the error.

Solution:

Remove the dist directory from the list of DAPPER_OUTPUT environment variable in the Dockerfile.dapper file.

Related Issue:

Test plan:

Check the GitHub Actions output.

[Yu-Jack]

LGTM