only prevent default on touchevents when results are not showing (#2725)

* only prevent default on touchevents when results are not showing fixes #2443 * stop is not the same as preventDefault
harvesthq · Oct 27, 2016 · bd47b88 · bd47b88
1 parent 23a3ee6
commit bd47b88
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/coffee/chosen.jquery.coffee b/coffee/chosen.jquery.coffee
@@ -69,8 +69,8 @@ class Chosen extends AbstractChosen
     @form_field_jq.trigger("chosen:ready", {chosen: this})
 
   register_observers: ->
-    @container.bind 'touchstart.chosen', (evt) => this.container_mousedown(evt); evt.preventDefault()
-    @container.bind 'touchend.chosen', (evt) => this.container_mouseup(evt); evt.preventDefault()
+    @container.bind 'touchstart.chosen', (evt) => this.container_mousedown(evt); return
+    @container.bind 'touchend.chosen', (evt) => this.container_mouseup(evt); return
 
     @container.bind 'mousedown.chosen', (evt) => this.container_mousedown(evt); return
     @container.bind 'mouseup.chosen', (evt) => this.container_mouseup(evt); return
@@ -129,7 +129,7 @@ class Chosen extends AbstractChosen
   container_mousedown: (evt) ->
     return if @is_disabled
 
-    if evt and evt.type is "mousedown" and not @results_showing
+    if evt and evt.type in ['mousedown', 'touchstart'] and not @results_showing
       evt.preventDefault()
 
     if not (evt? and ($ evt.target).hasClass "search-choice-close")

diff --git a/coffee/chosen.proto.coffee b/coffee/chosen.proto.coffee
@@ -50,8 +50,8 @@ class @Chosen extends AbstractChosen
     @form_field.fire("chosen:ready", {chosen: this})
 
   register_observers: ->
-    @container.observe "touchstart", (evt) => this.container_mousedown(evt); evt.preventDefault()
-    @container.observe "touchend", (evt) => this.container_mouseup(evt); evt.preventDefault()
+    @container.observe "touchstart", (evt) => this.container_mousedown(evt)
+    @container.observe "touchend", (evt) => this.container_mouseup(evt)
 
     @container.observe "mousedown", (evt) => this.container_mousedown(evt)
     @container.observe "mouseup", (evt) => this.container_mouseup(evt)
@@ -124,8 +124,8 @@ class @Chosen extends AbstractChosen
   container_mousedown: (evt) ->
     return if @is_disabled
 
-    if evt and evt.type is "mousedown" and not @results_showing
-      evt.stop()
+    if evt and evt.type in ['mousedown', 'touchstart'] and not @results_showing
+      evt.preventDefault()
 
     if not (evt? and evt.target.hasClassName "search-choice-close")
       if not @active_field