Use selectedIndex instead of value for tracking change events. #1147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
looks good to me (except that the compiled files are conflicting with the other merge you did) |
|
The compiled files will get fixed when I merge master back in. Not sure how I did that, but here we are. |
|
@pfiller quite easy: you have not fetched the latest master branch before creating your feature branch |
Conflicts: chosen/chosen.jquery.min.js chosen/chosen.proto.min.js
|
@stof I knew technically what happened. Just not sure how my fingers did that :-P It's fixed. |
Conflicts: chosen/chosen.jquery.min.js chosen/chosen.proto.js chosen/chosen.proto.min.js
pfiller
added a commit
that referenced
this pull request
Apr 18, 2013
Use selectedIndex instead of value for tracking change events.
pfiller
added a commit
that referenced
this pull request
Apr 19, 2013
Better container reference #1151 Fix issue when destroying last choice #1149 Use selectedIndex for tracking change events. #1147 Better IE Disabling #1144 Dropdown use css positioning for top position #1143 Fix bug when deleting last item #1142 Percentage Width Support #1141 CSS Centering Fix #1120 Use New CoffeeScript #1125 Chosen License #1111 Update placeholder text with ``liszt:updated`` #1107 Fix strange event bubbling #1055
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1024 and #962
Technically, a change event on a native select fires when the selected option changes -- regardless of value. We should track the
selectedIndexinstead of value to do our best to match this behavior.Note: this won't affect multiple select which already triggers a change event any time an option is selected or deselected.