Add note that Chosen is disabled on mobile #1741
Conversation
| @@ -1430,7 +1430,7 @@ | |||
| </li> | |||
| <li> | |||
| <h3>What browsers are supported?</h3> | |||
| <p>All modern browsers are supported (Firefox, Chrome, Safari and IE9). Legacy support for IE8 is also enabled.</p> | |||
| <p>All modern desktop browsers are supported (Firefox, Chrome, Safari and IE9). Legacy support for IE8 is also enabled. Chosen is disabled on iPhone, iPod, and Android devices (<a href="https://github.com/harvesthq/chosen/pull/1388">more information</a>).</p> | |||
There was a problem hiding this comment.
shouldn't it be iPad rather than iPod ?
There was a problem hiding this comment.
iPad is supported, iPod is iPod touch ;)
There was a problem hiding this comment.
Yeah -- that made the copy a little complicated. I wanted to simply say "iOS", but that's inaccurate, because iPad is still supported.
There was a problem hiding this comment.
is it also disabled on Android for tablets ?
There was a problem hiding this comment.
There was a problem hiding this comment.
That depends on the vendor of the browser. According to a comment here http://stackoverflow.com/a/5344382/189431 some vendors (read; Samsung) do add Mobile to the user-agent of tablet devices.
There was a problem hiding this comment.
Updated the copy slightly here: 589d211
|
LGTM. |
Add note that Chosen is disabled on mobile
@harvesthq/chosen-developers Follow up on this comment -- we never actually note anywhere that Chosen is disabled by default on iPhone/Android, and that the supported browsers we mention are the desktop versions of those browsers.