Fix for issues/1595 #1971
Closed
Fix for issues/1595 #1971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…roup's label instead 'undefined'
| @@ -166,6 +166,9 @@ class AbstractChosen | |||
|
|
|||
| else if option.group_array_index? and @results_data[option.group_array_index].search_match | |||
| option.search_match = true | |||
| if option.group and not @group_search | |||
| option.search_text = option.label | |||
There was a problem hiding this comment.
I would rather move the definition of option.search_text before the unless line, to avoid duplicating it.
There was a problem hiding this comment.
You are right, thanks
| @@ -149,7 +149,8 @@ class AbstractChosen | |||
| results_group = @results_data[option.group_array_index] | |||
| results += 1 if results_group.active_options is 0 and results_group.search_match | |||
| results_group.active_options += 1 | |||
|
|
|||
|
|
|||
| option.search_text = option.label | |||
There was a problem hiding this comment.
you should move the line option.search_text = if option.group then option.label else option.text which is a bit below instead of adding a different definition of the property
There was a problem hiding this comment.
That is my inattention, sorry. Done :-)
|
This commit got behind master due to the fact that it's been open since June. Sorry about that. The new PR #2255 contains the fix and credits @k-zelenkov. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It makes possible search with 'group_search:false' option and print group's label instead 'undefined'