Adjust doc to actual code: disable_search_threshold #2378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, @micgro42! Do you mind squashing these down to one commit? Instructions here. |
Contrary to what the documentation currently states, the search input is actually hidden if there are fewer **or equal** number of options compared to disable_search_threshold . Actually disable_search_threshold is compared via a "<=" operator instead of an "<" operator to the number of options. See the current code: https://github.com/harvesthq/chosen/blob/9a1a59f15a9a50b38a2aeafc0bb0f95c7ca9348a/coffee/chosen.jquery.coffee#L192
|
done |
tjschuck
added a commit
that referenced
this pull request
Jul 28, 2015
Adjust doc to actual code: disable_search_threshold
|
Thanks @micgro42! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contrary to what the documentation currently states, the search input is actually hidden if there are fewer or equal number of options compared to disable_search_threshold .
See the current code for reference:
chosen/coffee/chosen.jquery.coffee
Line 192 in 9a1a59f