Remove check for "Mobile" on android devices #2468
Closed
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chosen has some issues on some android devices like the Nexus 9. This commit will deactivate chosen on all android devices.
When embedding chosen in a chrome extension, the keyboard shortcut includes the option key. If a chosen instance happens to be focused at the time, releasing the option key opens it, but shouldn't.
|
Thanks @mydea, but this PR is not currently merge-able because it combines 3 separate issues into one:
At the very least, these should be in separate PRs. The Android change is the one most likely to get merged given the above info. |
|
Hey! So, the 3. part is apparently a leftover upstream commit from harvesthq/master that was later removed again - It took me a while to figure out how that ended up here ;) I'll make another PR with just the android changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chosen has some issues on some android devices like the Nexus 9. This commit will deactivate chosen on all android devices.
See Issue #2443