jQuery 1.9 - $.browser removed #950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 18, 2012 14:10
Address jQuery 1.9 removing $.browser
|
As the only sniffing we need is the IE version, I think the regex could be far simpler |
| # Do no harm and return as soon as possible for unsupported browsers, namely IE6 and IE7 | ||
| # Continue on if running IE document type but in compatibility mode | ||
| return this if $.browser.msie and ($.browser.version is "6.0" or ($.browser.version is "7.0" and document.documentMode is 7 )) | ||
| return this if browser.name.msie and (browser.version is "6.0" or (browser.version is "7.0" and document.documentMode is 7 )) |
There was a problem hiding this comment.
browser.name.msie is not defined by your change. what you are would need to check is browser.name is "msie"
|
+1 - Chosen is broken with jQuery 1.9 right now |
|
thanks |
|
@pfiller you should do a new release containing this fix as jQuery 1.9 is now stable |
|
Any word on a release? jQuery 1.9 has been the default for a month now. |
|
bump |
1 similar comment
|
bump |
|
+1 bump |
|
ping |
|
@adrienbrault use the master branch instead of the tag, as said above. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I tested the latest beta of jQuery the chosen plugin throws an error. Since jQuery 1.9 has removed $.browser I added the user agent sniffing.