Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle test failures with no message #3

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Conversation

mrsimo
Copy link
Member

@mrsimo mrsimo commented Apr 11, 2024

/cc @harvesthq/ep and @pusewicz @maria-faulisi @braddunbar who encountered these

In this build (and others) it seems like there's a new type of test failure that produce a junit file a bit different from what we've seen until now. The culprit is this error element that looks like:

<error type='OpenSSL::Cipher::CipherError' message="">

The code expected the message to always be present, it seems. I've made it fallback to use the type when there's no message. This repo is already a fork of the original plugin, because it didn't show things the way we liked (back in the day), I'm not planning to look much further than this :P

@mrsimo
Copy link
Member Author

mrsimo commented Apr 11, 2024

We have no CI for this repo, which is a bit funny. Locally they pass:

❯ ruby ruby/tests/annotate_test.rb
Run options: --seed 23438

# Running:

..

Finished in 0.285979s, 6.9935 runs/s, 13.9870 assertions/s.
2 runs, 4 assertions, 0 failures, 0 errors, 0 skips

@mrsimo
Copy link
Member Author

mrsimo commented Apr 11, 2024

Gonna go ahead and figure out how to release this

@mrsimo mrsimo merged commit d31c980 into master Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant