This repository has been archived by the owner on Apr 25, 2023. It is now read-only.
Adding past gov roles #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a party within the given ranges
The member API currently have a 'roles' field that contains the current role, to keep backward compatibility the new data was added under the `detailed_roles` fields. The new roles data is still not displayed on the MKs pages.
…d postgres + remove print
|
We've (@galchss) hand collected this data for the new Opening the Budget site, including exact periods. Feel free to use it: https://docs.google.com/spreadsheet/ccc?key=0AurnydTPSIgUdDliMkM2WXpUdjRwQUs2YWt1akdpaGc&usp=drive_web#gid=0 |
|
@ofri / @MeirKriheli take a look at it, i'm on vacation. Its better if we merge soon so master doesn't diverge too far from the PR |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By scraping the Knesset site, I added information about gov roles of the MKs. For now it's only in the API and not in the display.
I'm also not sure how to "crontab" the scraper.
Thanks,
Benny