Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-Setup a Functional Testing Framework #275

Closed
yotammanor opened this issue Jul 15, 2017 · 1 comment · Fixed by #320
Closed

Re-Setup a Functional Testing Framework #275

yotammanor opened this issue Jul 15, 2017 · 1 comment · Fixed by #320

Comments

@yotammanor
Copy link

Requirements and Specifications:

  • Executing the test suite will be done by running python manage.py test as is conventional in Django-based applications.
  • Testing will work both locally and in travis-CI, and will execute the same tests.
    • build steps in travis-CI will be declared in .travis.yml file.
    • build steps for local environment will be declared in Vagrantfile.
  • Testing framework should have the following characteristics:
    • Based on a common Python testing framework, preferably pytest.
    • Testing Framework is built and optimized for Functional Testing and (somewhat) below. No Orchestration testing, no data pipeline monitoring
    • Test Cases don't rely on existing DB state in order to run tests. Tests create their own objects (Knesset, Parties, MKs etc.) in order to test the site's behavior. Possibly with Factory Boy.
  • The current travis build runs the tests in kikar/tests/test_get_basic_pages.py, which implement a sanity-check suite that the main url endpoints in kikar return a 200 status code. Those tests may be rewritten, but the sanity check should be at least maintained.
  • Otherwise, All existing testing loose-ends (frameworks and test-cases) will be integrated and/or removed.
@yotammanor
Copy link
Author

  • No pytest at the moment, we are currently sticking with Django's default test runner.
  • Factory Boy was installed and utilized.
  • Tests were written using the new framework. Only existing tests were rewritten, no new tests added.
  • Travis was updated to run tests in current form

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant