Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timeline graph at the dashboard (אחוזי יציאה מסך הנסיעות לפי זמן) should be reversed #139

Closed
VSciFlight opened this issue Oct 21, 2023 · 10 comments
Assignees

Comments

@VSciFlight
Copy link
Contributor

The timeline graph should be reversed on the X-axis as time increasing when date is getting closest to the latest date

this image is showing module right now:
image

@AlexKomanov
Copy link
Contributor

AlexKomanov commented Oct 21, 2023

@VSciFlight - It looks like the issue is the inherited direction of the application.

According to the investigation - it is the "Recharts" library that is used to draw these charts (correct me if I was mistaken).

This one can be fixed by applying a reversed={true} prop to the <XAxis> component.

The fix can be applied here

After applying the mentioned prop - a charts graph looks like the following:

image

Also, there is another question here. Should we also change the location of the YAxis? To be in the opposite orientation like this?

image

@NoamGaash
Please assign this one to me. What I mentioned should fix this issue. Or maybe there is another solution that you can think about and I'll be happy to execute.

@AlexKomanov
Copy link
Contributor

@NoamGaash
What about this one?
Can I start to work on it?

@NoamGaash
Copy link
Member

@AlexKomanov
sure! thanks

@NoamGaash
Copy link
Member

@AlexKomanov @shootermv
just one question - are we sure that the X axis shouldn't be RTL, since the application is in Hebrew?

@VSciFlight
Copy link
Contributor Author

@NoamGaash
Yes, intuitively you see time (values in general) increasing as it goes to the right, like mathematical plots (XY).

But also depends on requirements if they say otherwise.

@AlexKomanov
Copy link
Contributor

AlexKomanov commented Oct 23, 2023

@NoamGaash
I am not a part of the group from where you shared a link. Can you please share here a screenshot?

Also, what is our action item here? To reverse the XAxis to be like the following?

image

cc: @VSciFlight

@VSciFlight
Copy link
Contributor Author

@AlexKomanov
Yeah, I needed to mention that

@NoamGaash
Copy link
Member

image

@ArkadiK94
Copy link
Collaborator

@NoamGaash @shootermv I close this issue because the related pr was merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants