Reverse the timeline graph XAxis to be with 'ltr' orientation #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexKomanov
changed the title
shootermv
requested changes
Oct 23, 2023
| @@ -57,7 +57,7 @@ export default function ArrivalByTimeChart({ | |||
| bottom: 5, | |||
| }}> | |||
| <CartesianGrid strokeDasharray="3 3" /> | |||
| <XAxis dataKey="gtfs_route_date" /> | |||
| <XAxis dataKey="gtfs_route_date" reversed={true}/> | |||
There was a problem hiding this comment.
according to prettier - there is missing space before closing space
There was a problem hiding this comment.
Oh. Fixing ASAP!
There was a problem hiding this comment.
You can run 'yarn lint' to see the linter outputs :)
shootermv
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The timeline graph at the dashboard (אחוזי יציאה מסך הנסיעות לפי זמן) was changed to be ltr even though the application is in Hebrew (basically with rtl orientation.
See the screenshot below.
This one closes the issue #139
screenshots