Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: lint errors #450 #573

Merged
merged 1 commit into from
Mar 13, 2024
Merged

fix: lint errors #450 #573

merged 1 commit into from
Mar 13, 2024

Conversation

yoavsbg
Copy link
Collaborator

@yoavsbg yoavsbg commented Mar 13, 2024

Description

Fix the following lint errors:

'@typescript-eslint/no-unsafe-return',
'@typescript-eslint/no-unsafe-argument'

added lint error ignore as there was errors in tests/visual.spec.ts:
'@typescript-eslint/no-unsafe-call'

@yoavsbg yoavsbg requested a review from NoamGaash as a code owner March 13, 2024 07:28
NoamGaash
NoamGaash approved these changes Mar 13, 2024
View reviewed changes
Copy link
Member

@NoamGaash NoamGaash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks great, thank you! :)

@yoavsbg yoavsbg merged commit bf8632b into hasadna:main Mar 13, 2024
17 checks passed
@github-actions github-actions bot mentioned this pull request Mar 13, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NoamGaash NoamGaash NoamGaash approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yoavsbg @NoamGaash