Fix lint issues

[NoamGaash]

open eslint.config.js
delete lines with rules that are turned 'off'. After deleting each line, run npm run lint, fix all warnings, and commit the changes.
It's recommended to make multiple pull requests, in order to break down this task,
this task can have multiple assignees.

• '@typescript-eslint/no-unsafe-call': 'off',
• '@typescript-eslint/no-unsafe-member-access': 'off',
• '@typescript-eslint/no-unsafe-return': 'off',
• '@typescript-eslint/no-floating-promises': 'off',
• '@typescript-eslint/restrict-template-expressions': 'off',
• '@typescript-eslint/no-base-to-string': 'off',
• '@typescript-eslint/no-unsafe-assignment': 'off',
• '@typescript-eslint/no-unsafe-argument': 'off',

also, deleting eslint-disable comments would be amazing.

[LightDDark]

@NoamGaash can you assign this issue to me?

[NoamGaash]

@LightDDark sure!
please use the checkboxes in the issue description to tell everyone what you're working on

[LightDDark]

Thank you!

• '@typescript-eslint/no-unsafe-call': 'off',

• '@typescript-eslint/no-unsafe-member-access': 'off',
• '@typescript-eslint/no-unsafe-return': 'off',
• '@typescript-eslint/no-floating-promises': 'off',
• '@typescript-eslint/restrict-template-expressions': 'off',
• '@typescript-eslint/no-base-to-string': 'off',
• '@typescript-eslint/no-unsafe-assignment': 'off',
• '@typescript-eslint/no-unsafe-argument': 'off',

[LightDDark]

I've encountered a problem in utils.ts file, the original code:

export const test = baseTest.extend({
  context: async ({ context }, use) => {
    await context.addInitScript(() =>
      window.addEventListener('beforeunload', () =>
        (window as any).collectIstanbulCoverage(JSON.stringify((window as any).__coverage__)),
      ),
    )
    // more code
  },
})

Naturally after deleting '@typescript-eslint/no-unsafe-call': 'off' it'll cause a linting error,
However changing any to Window doesn't fix it (after adding the necessary attributes for it to work), nor defining a new interface inside the function.
It seems window becomes any regardless of anything, after some research I think it's related to the issue described over here .

[NoamGaash]

@LightDDark that code piece is an anomaly - I think adding eslint-ignore-line is justified for this one

[yoavsbg]

Hi @NoamGaash
I can take this rules:
'@typescript-eslint/no-unsafe-return',
'@typescript-eslint/no-unsafe-argument'
can you please assign it to me?

[NoamGaash]

sure, thanks!