Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add filter on worst buses #54

Merged
merged 5 commits into from
Oct 2, 2023
Merged

Conversation

moshe742
Copy link
Contributor

No description provided.

Copy link
Member

@NoamGaash NoamGaash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!
Please consider my comment (I'm available to discuss it).

quick tip - you can run the linter locally using the npm run lint command

Comment on lines 34 to 35
const { search, setSearch } = useContext(SearchContext)
const { operatorId, lineNumber, timestamp, routes, routeKey } = search
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const { search, setSearch } = useContext(SearchContext)
const { operatorId, lineNumber, timestamp, routes, routeKey } = search
const [operatorId, setOperatorId] = useState('')

will be easier.
we don't need the entire search context here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@NoamGaash NoamGaash self-requested a review September 26, 2023 14:15
Copy link
Member

@NoamGaash NoamGaash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great! thank you 🙏

@NoamGaash NoamGaash merged commit 32b5792 into hasadna:main Oct 2, 2023
4 checks passed
@ArkadiK94 ArkadiK94 mentioned this pull request Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants