-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style: singleLineMap component #723
Conversation
…reen for bigger map
this is a screenshot of youtubModel which includes a description for the page |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! that's a good improvement, feel free to merge when you'll feel it's ready
@@ -123,79 +121,70 @@ const SingleLineMapPage = () => { | |||
{t('singleline_map_page_title')} | |||
<InfoYoutubeModal | |||
label={t('open_video_about_this_page')} | |||
title={t('youtube_modal_info_title')} | |||
title={t('realtime_map_page_description')} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's not the description of the right page, and perhaps we should consider includith both title and paragraph in the modal
@all-contributors please add @zushar as code contributor Thanks for the great work! the page does look much better 🥳 |
@zushar already contributed before to code I couldn't determine any contributions to add, did you specify any contributions? |
Description
screenshots