Cache just the home page. Fix caching of offline page #852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n the page. Create a new cache for caching just the homepage. Clear the old cache routes to reduce cache size.
jace
requested changes
Sep 2, 2020
| @@ -0,0 +1,17 @@ | |||
| {% extends "layout.html.jinja2" %} | |||
| {% block title %}{% trans %}Logout{% endtrans %}{% endblock %} | |||
|
|
|||
There was a problem hiding this comment.
This needs a bit of content explaining that the logout is in progress. We have a similar case in meta_refresh.html.jinja2.
There was a problem hiding this comment.
This helps, but I was referring to the body. Users will see a blank page for a second or so. We might as well show "Logging out…" in the middle of the screen for that second.
jace
approved these changes
Sep 3, 2020
vidya-ram
added a commit
that referenced
this pull request
Nov 23, 2021
* Cache just the home page. Fix caching of offline page * On logout, render a logout template and clear service worker caches in the page. Create a new cache for caching just the homepage. Clear the old cache routes to reduce cache size. * Don't cache the JS files. Delete the cache routes and precache * Move clearing cache to homepage * Change logout page title * Remove flash message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.