Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move agelimit and newlimit into settings #30

Closed
jace opened this issue Jul 19, 2012 · 1 comment
Closed

Move agelimit and newlimit into settings #30

jace opened this issue Jul 19, 2012 · 1 comment

Comments

@jace
Copy link
Member

jace commented Jul 19, 2012

The agelimit and newlimit variables should be in settings. However, importing timedelta in the settings file is a no-no (no code in settings), so we do it like this:

# settings.py
AGE_LIMIT = {'days': 30}
NEW_LIMIT = {'days': 1}

# code
agelimit = timedelta(**app.config['AGE_LIMIT'])
newlimit = timedelta(**app.config['NEW_LIMIT'])
@ghost ghost assigned nigelbabu Jul 19, 2012
@ghost ghost mentioned this issue Sep 3, 2015
@jace
Copy link
Member Author

jace commented Sep 3, 2015

Since the 30 day age limit has now become a defining product feature, with hardcoded references to "30 days" in several places, I propose we forget about this. There is no pressing need to move it into settings.

@jace jace closed this as completed Sep 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants