Modified job page title to include company name and location #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jace @shreyas-satish I see that a lot of job post title already mentions the company name, e.g. -
What could be a good way to recognize company and location names in those titles and not show them on the front page tiles? |
|
For 9/10 job posts this PR will work. For that 1, the company and location in title tag might be redundant. |
|
I suppose the redundancy is okay because the title tag doesn't show up in UI in a browser with tabs. It's only for Google. |
| @@ -1,7 +1,7 @@ | |||
| {% extends "sheet.html" %} | |||
| {%- from "baseframe/forms.html" import ajaxform %} | |||
| {%- from "macros.html" import jobheader, stickie %} | |||
| {% block title %}{{ headline }}{% endblock %} | |||
| {% block title %}{{ headline }}, at {{ post.company_name }} in {{ post.location }}{% endblock %} | |||
There was a problem hiding this comment.
I'd avoid English words like "at" and "in". Use punctuation to separate instead. Ideally /.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #252.