-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incompatible with typing-extensions 4.6.x #1
Comments
v4.6.0 breaks bases (which multiformats etc use) https://github.com/hashberg-io/bases/issues/3
* run datastore emulator * run flake8 to detect aliased test names * pin typing-extensions to <4.6 for compatibility with multiformats * use anonymous creds in ndb client hashberg-io/typing-validation#1
is not compatible with pydantic v2. any updates? |
this seems a blocker for me. bump @sg495 |
Blocking us too. Anyone found any workarounds for running Pydantic 2.x on Python <3.11 with this (or |
@declension i just wrote my own and migrated https://github.com/MarshalX/python-libipld |
Thanks - different use case here I think but maybe I'll start working around too then |
feel free to contribute more functions that should be bond for your use case :) |
Resolves hashberg-io#1. This fix simply loads Literal from typing-extensions for python versions less than 3.11. Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
@sg495 identified the root cause here months ago in hashberg-io/multiformats#10 (comment) . any chance you all could get a fix for that in sometime soon? thank you in advance! |
also pin typing-extensions to <4.6.0 due to hashberg-io/typing-validation#1
For what its worth, I've been using the code from pull request #2 for the development version of the application I'm working on (Python 3.11, Pydantic >=2.0), and haven't seen any issues so far. Having a published version that has this fix would be great though. |
Apologies for the delay in this: personal issues have prevented me from keeping up with this over the past few months. I have now merged the pull request: I will run local tests and publish an updated version shortly. |
This has now been released on PyPI as v1.1.0. |
Hi! First of all, thank you for building and maintaining all of these IPLD libraries. They're awesome!
You may have already noticed that typing-extensions v4.6.0 made a change that broke this lib. Specifically, this is what I get when I
import bases
with it:Not an emergency. Thanks in advance for looking!
The text was updated successfully, but these errors were encountered: