Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new Bitwarden version #3033

Closed
TheAlgorythm opened this issue Nov 13, 2021 · 5 comments · Fixed by #3202
Closed

Support new Bitwarden version #3033

TheAlgorythm opened this issue Nov 13, 2021 · 5 comments · Fixed by #3202

Comments

@TheAlgorythm
Copy link

Bitwarden changed the static iteration count in the second round to 2 for local auth. This was the result of a discussion at the PoC of #2505.
I plead in favour of a version 2 with the second iteration count as a parameter.

@TheAlgorythm
Copy link
Author

Are there any updates? I would love contributing myself, but I can't yet write OpenCL.

@matrix
Copy link
Member

matrix commented Feb 8, 2022

Are there any updates? I would love contributing myself, but I can't yet write OpenCL.

write it in C or perl if you want speedup ;)

@TheAlgorythm
Copy link
Author

I don't think, that it would bring a speedup, as parts of pythons standard library are written in C.
I understand, that you or this FOSS project don't have any obligation towards a random guy from the internet.
I've already tried changing the OpenCL code, but I wasn't even able to start the recompile of the .cl file. Maybe I'm able to dive deeper into the topic during the upcoming semester break.

@matrix
Copy link
Member

matrix commented Feb 8, 2022

I don't think, that it would bring a speedup, as parts of pythons standard library are written in C. I understand, that you or this FOSS project don't have any obligation towards a random guy from the internet. I've already tried changing the OpenCL code, but I wasn't even able to start the recompile of the .cl file. Maybe I'm able to dive deeper into the topic during the upcoming semester break.

I simply gave you an advice, you are free to think what you think is best. In any case, by speedup I meant integration process on hashcat, not performance.

@TheAlgorythm
Copy link
Author

If I am able to implement it, should it be done as a version 2? Should this time also the second iteration count be configurable, so that hashcat don't have to be updated on a change of Bitwarden in the future?

jsteube added a commit that referenced this issue Mar 9, 2022
Added parameter for second PBKDF2 iteration count for -m 23400, fixes #3033
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants