Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build failing on MacOS #3601

Closed
willcrozi opened this issue Jan 28, 2023 · 3 comments
Closed

Build failing on MacOS #3601

willcrozi opened this issue Jan 28, 2023 · 3 comments
Labels
bug

Comments

@willcrozi
Copy link
Contributor

willcrozi commented Jan 28, 2023 •
edited
Loading

Building hashcat on MacOS (Mojave 10.14.6, Intel i5 CPU) fails on current master:

clang version:

$ clang --version
Apple LLVM version 10.0.1 (clang-1001.0.46.4)
Target: x86_64-apple-darwin18.7.0
Thread model: posix
InstalledDir: /Library/Developer/CommandLineTools/usr/bin

git bisect points to f1ff925:

f1ff925b6e71b12f6170a6a0b35c997e22743564 is the first bad commit
commit f1ff925b6e71b12f6170a6a0b35c997e22743564
Author: jsteube <jens.steube@gmail.com>
Date:   Tue Jan 17 19:25:40 2023 +0000

    Prepare rename macros in header files from _MACRO to MACRO

:040000 040000 bbed810723cf82ded741387c5162b5b0b92f40f3 9bcee690045d7d240149e9230d7d22e25f490838 M	OpenCL
:040000 040000 5167dd65fc8879cf5d8e672ac4146ec9df20e631 6e92d4609b8b79999f57af52a62d091a4250cf54 M	include

build output:

$ make 
clang -c -std=gnu99 -W -Wall -Wextra -Wno-typedef-redefinition -O2 -pipe -Iinclude/ -IOpenCL/ -Ideps/LZMA-SDK/C -Ideps/zlib -Ideps/zlib/contrib -Ideps/OpenCL-Headers -DWITH_BRAIN -Ideps/xxHash -DWITH_CUBIN -Ideps/unrar -DWITH_HWMON src/affinity.c -o obj/affinity.NATIVE.o -fpic
clang -c -std=gnu99 -W -Wall -Wextra -Wno-typedef-redefinition -O2 -pipe -Iinclude/ -IOpenCL/ -Ideps/LZMA-SDK/C -Ideps/zlib -Ideps/zlib/contrib -Ideps/OpenCL-Headers -DWITH_BRAIN -Ideps/xxHash -DWITH_CUBIN -Ideps/unrar -DWITH_HWMON src/autotune.c -o obj/autotune.NATIVE.o -fpic
...
output snipped here
...
clang -c -std=gnu99 -W -Wall -Wextra -Wno-typedef-redefinition -O2 -pipe -Iinclude/ -IOpenCL/ -Ideps/LZMA-SDK/C -Ideps/zlib -Ideps/zlib/contrib -Ideps/OpenCL-Headers -DWITH_BRAIN -Ideps/xxHash -DWITH_CUBIN -Ideps/unrar -DWITH_HWMON -D_7ZIP_ST deps/LZMA-SDK/C/CpuArch.c -o obj/CpuArch.LZMA.NATIVE.o -fpic
In file included from src/ext_metal.m:16:
In file included from /System/Library/Frameworks/Foundation.framework/Headers/Foundation.h:159:
In file included from /System/Library/Frameworks/Foundation.framework/Headers/NSAppleEventDescriptor.h:8:
In file included from /System/Library/Frameworks/ApplicationServices.framework/Headers/ApplicationServices.h:35:
In file included from /System/Library/Frameworks/CoreGraphics.framework/Headers/CoreGraphics.h:45:
In file included from /System/Library/Frameworks/CoreGraphics.framework/Headers/CGEvent.h:12:
In file included from /System/Library/Frameworks/CoreGraphics.framework/Headers/CGEventTypes.h:14:
/System/Library/Frameworks/IOKit.framework/Headers/hidsystem/IOLLEvent.h:581:5: error: unknown type name 'NXEvent'; did you mean 'KCEvent'?
    NXEvent             payload;
    ^
/System/Library/Frameworks/CoreServices.framework/Frameworks/OSServices.framework/Headers/KeychainCore.h:62:16: note: 'KCEvent' declared here
typedef UInt16 KCEvent;
               ^
In file included from src/ext_metal.m:16:
In file included from /System/Library/Frameworks/Foundation.framework/Headers/Foundation.h:159:
In file included from /System/Library/Frameworks/Foundation.framework/Headers/NSAppleEventDescriptor.h:8:
In file included from /System/Library/Frameworks/ApplicationServices.framework/Headers/ApplicationServices.h:35:
In file included from /System/Library/Frameworks/CoreGraphics.framework/Headers/CoreGraphics.h:45:
In file included from /System/Library/Frameworks/CoreGraphics.framework/Headers/CGEvent.h:12:
/System/Library/Frameworks/CoreGraphics.framework/Headers/CGEventTypes.h:83:41: error: use of undeclared identifier 'NX_ALPHASHIFTMASK'
  kCGEventFlagMaskAlphaShift =          NX_ALPHASHIFTMASK,
                                        ^
/System/Library/Frameworks/CoreGraphics.framework/Headers/CGEventTypes.h:84:41: error: use of undeclared identifier 'NX_SHIFTMASK'
  kCGEventFlagMaskShift =               NX_SHIFTMASK,
                                        ^
/System/Library/Frameworks/CoreGraphics.framework/Headers/CGEventTypes.h:85:41: error: use of undeclared identifier 'NX_CONTROLMASK'
  kCGEventFlagMaskControl =             NX_CONTROLMASK,
                                        ^
clang -c -std=gnu99 -W -Wall -Wextra -Wno-typedef-redefinition -O2 -pipe -Iinclude/ -IOpenCL/ -Ideps/LZMA-SDK/C -Ideps/zlib -Ideps/zlib/contrib -Ideps/OpenCL-Headers -DWITH_BRAIN -Ideps/xxHash -DWITH_CUBIN -Ideps/unrar -DWITH_HWMON -D_7ZIP_ST deps/LZMA-SDK/C/Delta.c -o obj/Delta.LZMA.NATIVE.o -fpic
/System/Library/Frameworks/CoreGraphics.framework/Headers/CGEventTypes.h:86:41: error: use of undeclared identifier 'NX_ALTERNATEMASK'
  kCGEventFlagMaskAlternate =           NX_ALTERNATEMASK,
                                        ^
/System/Library/Frameworks/CoreGraphics.framework/Headers/CGEventTypes.h:87:41: error: use of undeclared identifier 'NX_COMMANDMASK'
  kCGEventFlagMaskCommand =             NX_COMMANDMASK,
                                        ^
/System/Library/Frameworks/CoreGraphics.framework/Headers/CGEventTypes.h:90:41: error: use of undeclared identifier 'NX_HELPMASK'
  kCGEventFlagMaskHelp =                NX_HELPMASK,
                                        ^
/System/Library/Frameworks/CoreGraphics.framework/Headers/CGEventTypes.h:91:41: error: use of undeclared identifier 'NX_SECONDARYFNMASK'
  kCGEventFlagMaskSecondaryFn =         NX_SECONDARYFNMASK,
                                        ^
/System/Library/Frameworks/CoreGraphics.framework/Headers/CGEventTypes.h:94:41: error: use of undeclared identifier 'NX_NUMERICPADMASK'
  kCGEventFlagMaskNumericPad =          NX_NUMERICPADMASK,
                                        ^
clang -c -std=gnu99 -W -Wall -Wextra -Wno-typedef-redefinition -O2 -pipe -Iinclude/ -IOpenCL/ -Ideps/LZMA-SDK/C -Ideps/zlib -Ideps/zlib/contrib -Ideps/OpenCL-Headers -DWITH_BRAIN -Ideps/xxHash -DWITH_CUBIN -Ideps/unrar -DWITH_HWMON -D_7ZIP_ST deps/LZMA-SDK/C/LzmaDec.c -o obj/LzmaDec.LZMA.NATIVE.o -fpic
/System/Library/Frameworks/CoreGraphics.framework/Headers/CGEventTypes.h:97:41: error: use of undeclared identifier 'NX_NONCOALSESCEDMASK'
  kCGEventFlagMaskNonCoalesced =        NX_NONCOALSESCEDMASK
                                        ^
/System/Library/Frameworks/CoreGraphics.framework/Headers/CGEventTypes.h:103:18: error: use of undeclared identifier 'NX_NULLEVENT'
  kCGEventNull = NX_NULLEVENT,
                 ^
/System/Library/Frameworks/CoreGraphics.framework/Headers/CGEventTypes.h:106:27: error: use of undeclared identifier 'NX_LMOUSEDOWN'
  kCGEventLeftMouseDown = NX_LMOUSEDOWN,
                          ^
/System/Library/Frameworks/CoreGraphics.framework/Headers/CGEventTypes.h:107:25: error: use of undeclared identifier 'NX_LMOUSEUP'
  kCGEventLeftMouseUp = NX_LMOUSEUP,
                        ^
clang -c -std=gnu99 -W -Wall -Wextra -Wno-typedef-redefinition -O2 -pipe -Iinclude/ -IOpenCL/ -Ideps/LZMA-SDK/C -Ideps/zlib -Ideps/zlib/contrib -Ideps/OpenCL-Headers -DWITH_BRAIN -Ideps/xxHash -DWITH_CUBIN -Ideps/unrar -DWITH_HWMON -D_7ZIP_ST deps/LZMA-SDK/C/Lzma2Dec.c -o obj/Lzma2Dec.LZMA.NATIVE.o -fpic
/System/Library/Frameworks/CoreGraphics.framework/Headers/CGEventTypes.h:108:28: error: use of undeclared identifier 'NX_RMOUSEDOWN'
  kCGEventRightMouseDown = NX_RMOUSEDOWN,
                           ^
/System/Library/Frameworks/CoreGraphics.framework/Headers/CGEventTypes.h:109:26: error: use of undeclared identifier 'NX_RMOUSEUP'
  kCGEventRightMouseUp = NX_RMOUSEUP,
                         ^
/System/Library/Frameworks/CoreGraphics.framework/Headers/CGEventTypes.h:110:24: error: use of undeclared identifier 'NX_MOUSEMOVED'
  kCGEventMouseMoved = NX_MOUSEMOVED,
                       ^
/System/Library/Frameworks/CoreGraphics.framework/Headers/CGEventTypes.h:111:30: error: use of undeclared identifier 'NX_LMOUSEDRAGGED'
  kCGEventLeftMouseDragged = NX_LMOUSEDRAGGED,
                             ^
/System/Library/Frameworks/CoreGraphics.framework/Headers/CGEventTypes.h:112:31: error: use of undeclared identifier 'NX_RMOUSEDRAGGED'
  kCGEventRightMouseDragged = NX_RMOUSEDRAGGED,
                              ^
/System/Library/Frameworks/CoreGraphics.framework/Headers/CGEventTypes.h:115:21: error: use of undeclared identifier 'NX_KEYDOWN'
  kCGEventKeyDown = NX_KEYDOWN,
                    ^
fatal error: too many errors emitted, stopping now [-ferror-limit=]
clang -c -std=gnu99 -W -Wall -Wextra -Wno-typedef-redefinition -O2 -pipe -Iinclude/ -IOpenCL/ -Ideps/LZMA-SDK/C -Ideps/zlib -Ideps/zlib/contrib -Ideps/OpenCL-Headers -DWITH_BRAIN -Ideps/xxHash -DWITH_CUBIN -Ideps/unrar -DWITH_HWMON -D_7ZIP_ST deps/LZMA-SDK/C/Sha256.c -o obj/Sha256.LZMA.NATIVE.o -fpic
clang -c -std=gnu99 -W -Wall -Wextra -Wno-typedef-redefinition -O2 -pipe -Iinclude/ -IOpenCL/ -Ideps/LZMA-SDK/C -Ideps/zlib -Ideps/zlib/contrib -Ideps/OpenCL-Headers -DWITH_BRAIN -Ideps/xxHash -DWITH_CUBIN -Ideps/unrar -DWITH_HWMON -D_7ZIP_ST deps/LZMA-SDK/C/Sha256Opt.c -o obj/Sha256Opt.LZMA.NATIVE.o -fpic
20 errors generated.
make: *** [obj/ext_metal.NATIVE.o] Error 1
make: *** Waiting for unfinished jobs....
@willcrozi willcrozi added the bug label Jan 28, 2023
@willcrozi
Copy link
Contributor Author

willcrozi commented Jan 28, 2023 •
edited
Loading

Narrowed it down to the rename of EVENT_H macro in include/event.h, I imagine it must be colliding with some part of an Apple library.

@jsteube
Copy link
Member

jsteube commented Jan 29, 2023

I've renamed it with latest comment, but don't have a Mac to test it on. Is it fixed?

@willcrozi
Copy link
Contributor Author

Yes that builds fine! 👍

@matrix matrix closed this as completed Apr 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@willcrozi @jsteube @matrix