Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abort session after NUM seconds of runtime - changes required? #472

Closed
d2-d2 opened this issue Aug 26, 2016 · 5 comments
Closed

Abort session after NUM seconds of runtime - changes required? #472

d2-d2 opened this issue Aug 26, 2016 · 5 comments

Comments

@d2-d2
Copy link

d2-d2 commented Aug 26, 2016

Hi,

Currently, with runtime parameter hashcat is working for X seconds. But if you press pause in the meantime, the counter do not stop. When you unpause hashcat and time is up then hashcat will terminate session.

I'm wondering if that should be changed. Talked with atom about it and here are two propositions:

  1. runtime=X describes for how long hashcat will work, regardles if you hit pause or not (timer stops when hashcat is paused, if you unpause it it will continue to run for X remaining seconds)
  2. runtime=X sets a general timer, when time is up, hashcat will be terminated not matter if it's paused or not

What do you people think? Which option would be better? Or maybe this initial behaviour shouldn't be changed at all?

@roycewilliams
Copy link
Member

roycewilliams commented Sep 1, 2016

  1. I think that most users would expect pausing to trump (take priority over) the timer. That's what I would expect, anyway. :)

@dropdeadfu
Copy link
Contributor

1 - pause should also pause the timer

@magnumripper
Copy link
Contributor

I agree, 1. is what I would expect

@jsteube
Copy link
Member

jsteube commented Sep 3, 2016

All right, will do :)

@jsteube
Copy link
Member

jsteube commented Sep 3, 2016

Done

@jsteube jsteube closed this as completed Sep 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants