Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added hash-mode: sha256(sha256_bin(pass)) #2125

Merged
merged 4 commits into from Jul 31, 2019

Conversation

matrix
Copy link
Member

@matrix matrix commented Jul 20, 2019

@matrix matrix changed the title Add Double sha256 kernel module Added hash-mode: sha256_hex(sha256_bin(pass)) Jul 27, 2019
@jsteube
Copy link
Member

jsteube commented Jul 30, 2019

two comments:

  • Please update hash-mode number to next one free, xx70 can't be used they are reserved for hmac variants.
  • That this mode will be very simar to sha256(sha256(p).s) which I saw you also send in a PR. For those modes there's special handling, see mode 2710 (and 2711 respectively). The 2710 and 2711 modes use the general 2710 kernel. The 2710 is the general mode ha256(sha256(p).s) and the last number is a specific application using this mode. This way we can add constraints like salt length, password length, etc from the application itself into the module.

@jsteube
Copy link
Member

jsteube commented Jul 30, 2019

One more comment:

  • Please do not use _hex. In case we omit that, we always refer to _hex (as in all other modules).

@jsteube
Copy link
Member

jsteube commented Jul 31, 2019

I just saw that this module is not sha256 (hex) twice. Therefore this need to be a standalone mode. The following action is needed to merge:

  • Rename the hashmode to the next one free
  • Rename the mode from sha256_hex(sha256_bin(pass)) to sha256(sha256_bin(pass))
  • Fix conflicts with docs/*

@matrix matrix changed the title Added hash-mode: sha256_hex(sha256_bin(pass)) Added hash-mode: sha256(sha256_bin(pass)) Jul 31, 2019
@jsteube jsteube merged commit 9e9adfc into hashcat:master Jul 31, 2019
@matrix matrix deleted the double_sha256_1 branch July 31, 2019 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants