New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VeraCrypt strings #3302
Merged
Merged
VeraCrypt strings #3302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ventaquil
force-pushed
the
veracrypt-strings
branch
from
June 2, 2022 11:51
9c68ad0
to
5a0ad87
Compare
ventaquil
force-pushed
the
veracrypt-strings
branch
from
June 2, 2022 12:01
5a0ad87
to
678e951
Compare
Looks okay.
|
ventaquil
force-pushed
the
veracrypt-strings
branch
from
June 7, 2022 00:41
678e951
to
e1a8cd1
Compare
Referring to #3293 (comment) new modules 294XX were added. 137XX tests
294XX tests
|
ventaquil
force-pushed
the
veracrypt-strings
branch
from
June 7, 2022 08:15
e1a8cd1
to
55f1e96
Compare
ventaquil
force-pushed
the
veracrypt-strings
branch
from
June 7, 2022 21:09
55f1e96
to
b00ea48
Compare
Added legacy suffix (referring to #3293 (comment)) to distinguish between legacy modules and new ones. |
Hey @ventaquil is this ready for merge? |
Hey @jsteube, yep, this PR is ready. You can try to run tests for new modes on your own. |
Excellent. Many thanks :) |
You're welcome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar changes like in GH-3293 but for VeraCrypt modules.
Under production until GH-3293 will be merged.