Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Charts[Telemetry]: Parameterize the namespace #317

Closed
Tracked by #111
leninmehedy opened this issue Sep 7, 2023 · 1 comment · Fixed by #351
Closed
Tracked by #111

Charts[Telemetry]: Parameterize the namespace #317

leninmehedy opened this issue Sep 7, 2023 · 1 comment · Fixed by #351
Assignees
@leninmehedy
Labels
released
Milestone
v0.9.x

Comments

@leninmehedy
Copy link
Member

leninmehedy commented Sep 7, 2023 •
edited
Loading 

          We will need to parameterize the namespace in the future, 'default' is temporary during development.

Originally posted by @jeromy-cannon in #298 (comment)

Nathan Klick:
some helm charts also will have a values file option of namespaceOverride: "" and use a namespace: {{ default .Release.Namespace .Values.namespaceOverride }} ```
@leninmehedy leninmehedy self-assigned this Sep 7, 2023
@leninmehedy leninmehedy mentioned this issue Sep 7, 2023
Merged
@nathanklick nathanklick changed the title Chart[Telemetry]: Parameterize the namespace Charts[Telemetry]: Parameterize the namespace Sep 11, 2023
@nathanklick nathanklick mentioned this issue Sep 11, 2023
Open
@nathanklick nathanklick added this to the v0.9.x milestone Sep 14, 2023
@leninmehedy leninmehedy mentioned this issue Sep 18, 2023
Merged
@leninmehedy leninmehedy linked a pull request Sep 18, 2023 that will close this issue
feat: parameterize the helm chart namespace value #351
Merged
@swirlds-automation
Copy link
Contributor

🎉 This issue has been resolved in version 0.12.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leninmehedy leninmehedy

Labels
released
Projects
FST Suite
Status: ✅ Done
Milestone
v0.9.x
Development

Successfully merging a pull request may close this issue.

feat: parameterize the helm chart namespace value hashgraph/full-stack-testing
3 participants
@leninmehedy @nathanklick @swirlds-automation