Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: optimize mirror node deployment and fix resources for root-container #813

Merged
merged 4 commits into from
Apr 4, 2024

Conversation

leninmehedy
Copy link
Member

Description

This pull request changes the following:

  • fix: resources for root container was not set properly in values yaml
  • do not set any limit for root container
  • disable account balance uploader
  • disable web3 for mirror nodes
  • enable monitor for mirror nodes

Related Issues

  • Closes #

@leninmehedy leninmehedy changed the title fix: do not set resources for root-container by default and enable monitor for mirror node deployment fix: enable monitor for mirror node deployment and fix resources for root-container Apr 2, 2024
@leninmehedy leninmehedy changed the title fix: enable monitor for mirror node deployment and fix resources for root-container fix: optimize mirror node deployment and fix resources for root-container Apr 2, 2024
Copy link

github-actions bot commented Apr 2, 2024

Unit Test Results

  26 files    26 suites   55s ⏱️
109 tests 105 ✔️ 4 💤 0
110 runs  106 ✔️ 4 💤 0

Results for commit 60b7d90.

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.17%. Comparing base (f86f0ff) to head (b1cce41).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #813   +/-   ##
=========================================
  Coverage     67.17%   67.17%           
  Complexity      339      339           
=========================================
  Files            64       64           
  Lines          1319     1319           
  Branches        157      157           
=========================================
  Hits            886      886           
  Misses          370      370           
  Partials         63       63           

Impacted file tree graph

@leninmehedy leninmehedy changed the title fix: optimize mirror node deployment and fix resources for root-container fix: optimize mirror node deployment and fix resources for root-container Apr 3, 2024
@leninmehedy leninmehedy force-pushed the fix-resources-for-root-container branch from b1cce41 to c1f2943 Compare April 3, 2024 20:54
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
It appears to be unused and not uploading anything from node

Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
@leninmehedy leninmehedy force-pushed the fix-resources-for-root-container branch from c1f2943 to 60b7d90 Compare April 3, 2024 20:55
Copy link

sonarcloud bot commented Apr 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@leninmehedy leninmehedy merged commit dbffd87 into main Apr 4, 2024
20 checks passed
@leninmehedy leninmehedy deleted the fix-resources-for-root-container branch April 4, 2024 06:38
swirlds-automation added a commit that referenced this pull request Apr 4, 2024
## [0.24.2](v0.24.1...v0.24.2) (2024-04-04)

### Bug Fixes

* optimize mirror node deployment and fix resources for root-container ([#813](#813)) ([dbffd87](dbffd87))
@swirlds-automation
Copy link
Contributor

🎉 This PR is included in version 0.24.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants