Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Guardian from 'old' CommonJS (CJS) modules to 'new' ECMAScript (ESM) modules #3140

Closed
anvabr opened this issue Jan 22, 2024 · 0 comments
Assignees

Comments

@anvabr
Copy link
Collaborator

anvabr commented Jan 22, 2024

Problem description

As of Node.js v12+ it natively supports ESM which are also supported by all modern browsers. Guardian interfaces multiple external systems, uses 3rd party libraries. We have already encountered a CJS/ESM incompatibility issue with w3up web3.storage libraries, and anticipate that such problems will occur increasingly more often.

Requirements

  • Convert Guardian existing CJS build system into ESM.
  • Note in the documentation that Guardian requires ESM modules (for those wishing to extend or modify Guardian codebase).

Definition of done

Guardian codebase is built with ESM technology.

Acceptance criteria

No impact on fictionality or clients.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants