Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NX Dependency Override - remove whenever possible #1636

Closed
AlfredoG87 opened this issue Aug 11, 2023 · 2 comments · Fixed by #2365
Closed

NX Dependency Override - remove whenever possible #1636

AlfredoG87 opened this issue Aug 11, 2023 · 2 comments · Fixed by #2365
Assignees
@AlfredoG87
Labels
dependencies Pull requests that update a dependency file
Milestone
0.47.0

Comments

@AlfredoG87
Copy link
Collaborator

AlfredoG87 commented Aug 11, 2023 •
edited by Nana-EC

once the dependency for NX fixes this issue, remove the override.

          We should note in comments why and when this override is no longer needed if possible

Originally posted by @Nana-EC in #1634 (comment)
@AlfredoG87 AlfredoG87 added the dependencies Pull requests that update a dependency file label Aug 11, 2023
@Nana-EC
Copy link
Collaborator

Nana-EC commented Apr 17, 2024

@AlfredoG87 is this still applicable?

@AlfredoG87 AlfredoG87 self-assigned this Apr 18, 2024
@AlfredoG87 AlfredoG87 added this to the 0.47.0 milestone Apr 18, 2024
@AlfredoG87 AlfredoG87 mentioned this issue Apr 18, 2024
Merged
2 tasks
@AlfredoG87
Copy link
Collaborator Author

we still have the dependency, not sure why

@AlfredoG87 is this still applicable?

I've created a PR for this, seems like the issue is resolved now. 👍

#2365

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlfredoG87 AlfredoG87

Labels
dependencies Pull requests that update a dependency file
Projects
Smart Contract Sprint Board
Status: Done
Milestone
0.47.0
2 participants
@Nana-EC @AlfredoG87