Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect platform status should prevent sync #11418

Closed
alittley opened this issue Feb 7, 2024 · 1 comment
Closed

Incorrect platform status should prevent sync #11418

alittley opened this issue Feb 7, 2024 · 1 comment
Assignees
Labels
Bug An error that causes the feature to behave differently than what was expected based on design.
Milestone

Comments

@alittley
Copy link
Contributor

alittley commented Feb 7, 2024

Problem

  • In the current system, platform status doesn't have an affect on whether a node syncs
    • Instead, we rely on gossip being started or stopped, and on the following checks before accepting or initiating a sync: fallen behind, reconnect complete, PCES replay complete
  • In the case of PCES replay complete, this approach causes undesirable behavior:
    • If the platform status state machine doesn’t transition out of REPLAYING_EVENTS due to a problem during replay, the node will start syncing regardless, wasting network resources and filling logs with errors about events that could not be added to the hashgraph.
  • Since the platform status has no direct affect on whether a node syncs or not, it is possible that an unknown bug could cause a node to sync even when the platform status indicates that the node should not!
    • Such a bug would be difficult to track down, since misleading status logs would indicate the node is not syncing, when it actually is

Solution

  • Introduce logic that prevents a node from syncing if the platform status isn't in the permissible list

  • Eventually, it would be good if we could always have gossip "started", and control whether or not we are syncing via platform status only

    • This would allow us to discard the racy gossip start/stop logic
@alittley alittley added this to the v0.48.0 milestone Feb 7, 2024
@alittley alittley self-assigned this Feb 7, 2024
@alittley alittley added the Bug An error that causes the feature to behave differently than what was expected based on design. label Feb 7, 2024
@alittley
Copy link
Contributor Author

alittley commented Feb 8, 2024

Done

@alittley alittley closed this as completed Feb 8, 2024
@poulok poulok modified the milestones: v0.48, v0.49 Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug An error that causes the feature to behave differently than what was expected based on design.
Projects
None yet
Development

No branches or pull requests

2 participants