Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine getVersionInfo to return Git tag used to build deployed JAR (not just current development version) #1188

Closed
2 tasks done
tinker-michaelj opened this issue Mar 19, 2021 · 0 comments · Fixed by #1339
Closed
2 tasks done
Assignees
Milestone

Comments

@tinker-michaelj
Copy link
Collaborator

tinker-michaelj commented Mar 19, 2021

Summary
We currently just "hard-code" the getVersionInfo query to return the contents of src/main/resources/semantic-version.properties.

It would be much more useful to remove this file from version control and automate its creation using Maven filtering during the build so that,

  • hapi.proto.version filters from${hapi-proto.version}.
  • hedera-services.version filters from${project.version}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants