Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update protobufs for HIP-18 #1586

Closed
7 tasks done
tinker-michaelj opened this issue Jun 13, 2021 · 2 comments
Closed
7 tasks done

Update protobufs for HIP-18 #1586

tinker-michaelj opened this issue Jun 13, 2021 · 2 comments
Assignees
Labels
Impact Potentially impacts SDK, clients, docs and/or users.
Milestone

Comments

@tinker-michaelj
Copy link
Collaborator

tinker-michaelj commented Jun 13, 2021

✅  Closed by hashgraph/hedera-protobufs#42

Summary
The TokenCreate and TokenUpdate transactions for a token T should allow the token admin to specify,

  • Zero or more fixed ℏ fees owed to custom account(s) when transferring units of T.
  • Zero or more fixed HTS unit fees owed to custom account(s) when transferring units of T.
  • Zero or more fractional-valued fees owed to custom account(s) when transferring units of T.

For fractional-valued HTS unit fees, it should also be possible to specify:

  • The minimum amount of units that may be assessed.
  • The maximum amount of units that may be assessed.

The TransactionRecord type should be expanded to include:

  • A assessedCustomFees list with the ℏ or HTS units owed to each custom collection account by the payer account.

The TokenInfo message should also:

  • Include the token's custom fee schedules and whether they can be updated using the token's adminKey.
@abhishek-hedera
Copy link
Contributor

I think the percentage based custom fees should be specific to the token being transferred and not to either ℏ fees or other token types. Any suggestions @qnswirlds ?

@tinker-michaelj
Copy link
Collaborator Author

Closed by hashgraph/hedera-protobufs#42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Impact Potentially impacts SDK, clients, docs and/or users.
Development

No branches or pull requests

3 participants